Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data: Avoid assuming persisted preferences shape #14692

Merged
merged 1 commit into from
Mar 29, 2019

Conversation

aduth
Copy link
Member

@aduth aduth commented Mar 28, 2019

Related: #14580, #14691

This pull request seeks to update references to persisted preferences objects to avoid assumed shape of individual property values within preferences. See #14580 for additional context.

Testing instructions:

Verify unit tests pass:

npm run test-unit

Extra credit: Verify no regressions in affected behavior (insert usage, feature activation, active sidebar, NUX dismissed tips).

@gziolo gziolo added [Type] Enhancement A suggestion for improvement. [Type] Code Quality Issues or PRs that relate to code quality labels Mar 29, 2019
@gziolo gziolo added this to the 5.4 (Gutenberg) milestone Mar 29, 2019
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thanks for doing an extensive audit of existing selectors 💯

@gziolo gziolo merged commit ae3a09e into master Mar 29, 2019
@gziolo gziolo deleted the update/avoid-assumed-preferences-shape branch March 29, 2019 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code Quality Issues or PRs that relate to code quality [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants