Upgrade Puppeteer to the latest version #14986

gziolo · 2019-04-15T14:32:37Z

Description

Upgrades puppeteer and related dependencies jest-puppeteer and expect-puppeteer to the latest versions.

This is necessary to let Firefox folks to run our e2e tests with Firefox browser, see https://bugzilla.mozilla.org/show_bug.cgi?id=1539202 for more details :)

As of today, Gutenberg uses Puppeteer v1.6.1 which uses Chromium 69.0.3494.0 (r575458). This PR updates Puppeteer to v1.17.0 which uses Chromium 76.0.3803.0 (r662092). It's worth emphasizing that we officially support only 2 latest versions of Chrome.

Disabled tests

I will add a more detailed list later...

Testing

npm run test-e2e locally and on Travis

gziolo · 2019-04-15T14:36:26Z

This is all failures I see on my local env:

Summary of all failing tests
 FAIL  specs/links.test.js (33.098s)
  ● Links › link popover remains visible after a mouse drag event

    expect(received).toHaveLength(expected)

    Expected length: 1
    Received length: 0
    Received array:  []

      476 |             // The link popover should still be visible
      477 |             const popover = await page.$$( '.block-editor-url-popover' );
    > 478 |             expect( popover ).toHaveLength( 1 );
          |                               ^
      479 |     } );
      480 | 
      481 |     it( 'should contain a label when it should open in a new tab', async () => {

      at Object.toHaveLength (specs/links.test.js:478:21)
      at tryCatch (../../node_modules/regenerator-runtime/runtime.js:62:40)
      at Generator.invoke [as _invoke] (../../node_modules/regenerator-runtime/runtime.js:288:22)
      at Generator.prototype.(anonymous function) [as next] (../../node_modules/regenerator-runtime/runtime.js:114:21)
      at asyncGeneratorStep (specs/links.test.js:15:103)
      at _next (specs/links.test.js:17:194)

 FAIL  specs/preview.test.js (10.067s)
  ● Preview › should open a preview window for a new post

    Error: failed to find element matching selector ".entry-title"



      at ElementHandle.$eval (../../node_modules/puppeteer/lib/JSHandle.js:418:13)
        -- ASYNC --
      at ElementHandle.<anonymous> (../../node_modules/puppeteer/lib/helper.js:110:27)
      at DOMWorld.$eval (../../node_modules/puppeteer/lib/DOMWorld.js:149:21)
        -- ASYNC --
      at Frame.<anonymous> (../../node_modules/puppeteer/lib/helper.js:110:27)
      at Page.$eval (../../node_modules/puppeteer/lib/Page.js:329:29)
      at Page.<anonymous> (../../node_modules/puppeteer/lib/helper.js:111:23)
      at Object._callee2$ (specs/preview.test.js:301:32)
      at tryCatch (../../node_modules/regenerator-runtime/runtime.js:62:40)
      at Generator.invoke [as _invoke] (../../node_modules/regenerator-runtime/runtime.js:288:22)
      at Generator.prototype.(anonymous function) [as next] (../../node_modules/regenerator-runtime/runtime.js:114:21)
      at asyncGeneratorStep (specs/preview.test.js:31:103)
      at _next (specs/preview.test.js:33:194)

  ● Preview › should not revert title during a preview right after a save draft

    Error: failed to find element matching selector ".entry-title"



      at ElementHandle.$eval (../../node_modules/puppeteer/lib/JSHandle.js:418:13)
        -- ASYNC --
      at ElementHandle.<anonymous> (../../node_modules/puppeteer/lib/helper.js:110:27)
      at DOMWorld.$eval (../../node_modules/puppeteer/lib/DOMWorld.js:149:21)
        -- ASYNC --
      at Frame.<anonymous> (../../node_modules/puppeteer/lib/helper.js:110:27)
      at Page.$eval (../../node_modules/puppeteer/lib/Page.js:329:29)
      at Page.<anonymous> (../../node_modules/puppeteer/lib/helper.js:111:23)
      at Object._callee3$ (specs/preview.test.js:458:32)
      at tryCatch (../../node_modules/regenerator-runtime/runtime.js:62:40)
      at Generator.invoke [as _invoke] (../../node_modules/regenerator-runtime/runtime.js:288:22)
      at Generator.prototype.(anonymous function) [as next] (../../node_modules/regenerator-runtime/runtime.js:114:21)
      at asyncGeneratorStep (specs/preview.test.js:31:103)
      at _next (specs/preview.test.js:33:194)

  ● Preview with Custom Fields enabled › displays edits to the post title and content in the preview

    Error: failed to find element matching selector ".entry-title"



      at ElementHandle.$eval (../../node_modules/puppeteer/lib/JSHandle.js:418:13)
        -- ASYNC --
      at ElementHandle.<anonymous> (../../node_modules/puppeteer/lib/helper.js:110:27)
      at DOMWorld.$eval (../../node_modules/puppeteer/lib/DOMWorld.js:149:21)
        -- ASYNC --
      at Frame.<anonymous> (../../node_modules/puppeteer/lib/helper.js:110:27)
      at Page.$eval (../../node_modules/puppeteer/lib/Page.js:329:29)
      at Page.<anonymous> (../../node_modules/puppeteer/lib/helper.js:111:23)
      at Object._callee6$ (specs/preview.test.js:619:32)
      at tryCatch (../../node_modules/regenerator-runtime/runtime.js:62:40)
      at Generator.invoke [as _invoke] (../../node_modules/regenerator-runtime/runtime.js:288:22)
      at Generator.prototype.(anonymous function) [as next] (../../node_modules/regenerator-runtime/runtime.js:114:21)
      at asyncGeneratorStep (specs/preview.test.js:31:103)
      at _next (specs/preview.test.js:33:194)

 FAIL  specs/demo.test.js
  ● new editor state › content should load without making the post dirty

    expect(jest.fn()).not.toHaveErrored(expected)

    Expected mock function not to be called but it was called with:
    ["Unhandled error"],["TypeError: Cannot read property 'replace' of undefined
        at replace (/Users/gziolo/PhpstormProjects/gutenberg/packages/e2e-tests/specs/demo.test.js:20:50)
        at Object.responseObjectTransform (/Users/gziolo/PhpstormProjects/gutenberg/packages/e2e-test-utils/build/mocks/@wordpress/e2e-test-utils/src/mocks/mock-or-transform.js:38:38)
        at tryCatch (/Users/gziolo/PhpstormProjects/gutenberg/node_modules/regenerator-runtime/runtime.js:62:40)
        at Generator.invoke [as _invoke] (/Users/gziolo/PhpstormProjects/gutenberg/node_modules/regenerator-runtime/runtime.js:288:22)
        at Generator.prototype.(anonymous function) [as next] (/Users/gziolo/PhpstormProjects/gutenberg/node_modules/regenerator-runtime/runtime.js:114:21)
        at asyncGeneratorStep (/Users/gziolo/PhpstormProjects/gutenberg/node_modules/@babel/runtime/helpers/asyncToGenerator.js:3:24)
        at _next (/Users/gziolo/PhpstormProjects/gutenberg/node_modules/@babel/runtime/helpers/asyncToGenerator.js:25:9)
        at process._tickCallback (internal/process/next_tick.js:68:7)"]

      at expect (../jest-console/build/@wordpress/jest-console/src/index.js:34:4)

 FAIL  specs/undo.test.js (5.679s)
  ● undo › Should undo to expected level intervals

    expect(received).not.toBeNull()

    Received: null

      62 |              expect( await getEditedPostContent() ).toBe( '' );
      63 |              // After undoing every action, there should be no more undo history.
    > 64 |              expect( await page.$( '.editor-history__undo[aria-disabled="true"]' ) ).not.toBeNull();
         |                                                                                          ^
      65 |      } );
      66 | } );
      67 | 

      at Object.toBeNull (specs/undo.test.js:64:79)
      at tryCatch (../../node_modules/regenerator-runtime/runtime.js:62:40)
      at Generator.invoke [as _invoke] (../../node_modules/regenerator-runtime/runtime.js:288:22)
      at Generator.prototype.(anonymous function) [as next] (../../node_modules/regenerator-runtime/runtime.js:114:21)
      at asyncGeneratorStep (specs/undo.test.js:9:103)
      at _next (specs/undo.test.js:11:194)


Test Suites: 4 failed, 66 passed, 70 total
Tests:       6 failed, 4 skipped, 371 passed, 381 total
Snapshots:   252 passed, 252 total
Time:        555.843s
Ran all test suites.

talldan · 2019-04-16T05:44:05Z

Did some debugging on the failure of Links › link popover remains visible after a mouse drag event.

For some reason, in this version of Chromium, the link popover's container is narrower with its content overflowing. When the test performs the drag event, it is actually clicking outside of the popover because of the size issue, which results in dismissal of the popover:

I wonder if this is actually a bug in this version of chromium (75.0.3738.0). I downloaded a later version (75.0.3768.0) and checked manually and the popover is normally sized.

(Conjecture) It could be that the test failures are related to the version of chromium more so than the puppeteer api. I noticed that the old version of puppeteer we were using was downloading chromium revision r575458, while the upgraded version downloads r641577.

talldan · 2019-04-16T06:30:33Z

I just tried it out in Puppeteer 1.12.2, which uses an earlier revision of chromium and that link test passes ok.

I also had a look at Preview › should open a preview window for a new post. This is also a strange issue. The second time the preview button is clicked, the preview tab becomes active and the editor tab closes. Not entirely sure why it closes.

I've pushed 5e0a0e7 to fix some of the preview tests.

I noticed #14994 which causes one of the other preview tests to fail, but seems like a genuine issue that we should fix separately.

gziolo · 2019-04-16T14:24:55Z

I've pushed 5e0a0e7 to fix some of the preview tests.

Many thanks for submitting the fix 👍

I'm also surprised seeing that there are more test failures with popular plugins enabled 🤷‍♂️

gziolo · 2019-04-23T17:44:49Z

FAIL specs/demo.test.js

This test should be fixed with c66f67f.

gziolo · 2019-04-24T07:20:32Z

I disabled WP Editor Meta Boxes test suite in 4cfb304. It should be further investigated separately as it seems to be fragile on its own.

gziolo · 2019-04-27T12:36:58Z

I'm down to 2 failures locally:

Summary of all failing tests
 FAIL  specs/links.test.js (24.435s)
  ● Links › link popover remains visible after a mouse drag event

    expect(received).toHaveLength(expected)

    Expected length: 1
    Received length: 0
    Received array:  []

      478 |             // The link popover should still be visible
      479 |             const popover = await page.$$( '.block-editor-url-popover' );
    > 480 |             expect( popover ).toHaveLength( 1 );
          |                               ^
      481 |     } );
      482 | 
      483 |     it( 'should contain a label when it should open in a new tab', async () => {

      at Object.toHaveLength (specs/links.test.js:480:21)
      at tryCatch (../../node_modules/regenerator-runtime/runtime.js:62:40)
      at Generator.invoke [as _invoke] (../../node_modules/regenerator-runtime/runtime.js:288:22)
      at Generator.prototype.(anonymous function) [as next] (../../node_modules/regenerator-runtime/runtime.js:114:21)
      at asyncGeneratorStep (specs/links.test.js:15:103)
      at _next (specs/links.test.js:17:194)

 FAIL  specs/rich-text.test.js (11.192s)
  ● RichText › should apply formatting with access shortcut

    expect(received).toMatchSnapshot()

    Snapshot name: `RichText should apply formatting with access shortcut 1`

    - Snapshot
    + Received

      "<!-- wp:paragraph -->
    - <p><s>test</s></p>
    + <p>test</p>
      <!-- /wp:paragraph -->"

      34 |              await pressKeyWithModifier( 'access', 'd' );
      35 | 
    > 36 |              expect( await getEditedPostContent() ).toMatchSnapshot();
         |                                                     ^
      37 |      } );
      38 | 
      39 |      it( 'should apply formatting with primary shortcut', async () => {

      at Object.toMatchSnapshot (specs/rich-text.test.js:36:42)
      at tryCatch (../../node_modules/regenerator-runtime/runtime.js:62:40)
      at Generator.invoke [as _invoke] (../../node_modules/regenerator-runtime/runtime.js:288:22)
      at Generator.prototype.(anonymous function) [as next] (../../node_modules/regenerator-runtime/runtime.js:114:21)
      at asyncGeneratorStep (specs/rich-text.test.js:11:103)
      at _next (specs/rich-text.test.js:13:194)

gziolo · 2019-04-27T18:27:17Z

I fixed the rich text test in e1334f0 and Puppeteer upgrade dbc196f resolved the other failure. However, there is another test with 2 failing snapshots which need to be investigated.

 FAIL  specs/writing-flow.test.js (17.96s)
  ● adding blocks › should navigate around nested inline boundaries

    expect(received).toMatchSnapshot()

    Snapshot name: `adding blocks should navigate around nested inline boundaries 1`

    - Snapshot
    + Received

      "<!-- wp:paragraph -->
    - <p><strong><em>1</em> <em>2</em></strong></p>
    + <p><strong>1 <em>2</em></strong></p>
      <!-- /wp:paragraph -->"

      148 |             await page.keyboard.press( 'ArrowLeft' );
      149 | 
    > 150 |             expect( await getEditedPostContent() ).toMatchSnapshot();
          |                                                    ^
      151 | 
      152 |             await page.keyboard.type( 'a' );
      153 |             await page.keyboard.press( 'ArrowRight' );

      at Object.toMatchSnapshot (specs/writing-flow.test.js:150:42)
      at tryCatch (../../node_modules/regenerator-runtime/runtime.js:62:40)
      at Generator.invoke [as _invoke] (../../node_modules/regenerator-runtime/runtime.js:288:22)
      at Generator.prototype.(anonymous function) [as next] (../../node_modules/regenerator-runtime/runtime.js:114:21)
      at asyncGeneratorStep (specs/writing-flow.test.js:9:103)
      at _next (specs/writing-flow.test.js:11:194)

  ● adding blocks › should navigate around nested inline boundaries

    expect(received).toMatchSnapshot()

    Snapshot name: `adding blocks should navigate around nested inline boundaries 2`

    - Snapshot
    + Received

      "<!-- wp:paragraph -->
    - <p>a<strong>b<em>c1d</em>e f<em>g2h</em>i</strong>j</p>
    + <p><strong><em>a</em>b1c d<em>e2f</em>g</strong>hij</p>
      <!-- /wp:paragraph -->"

      170 |             await page.keyboard.type( 'j' );
      171 | 
    > 172 |             expect( await getEditedPostContent() ).toMatchSnapshot();
          |                                                    ^
      173 |     } );
      174 | 
      175 |     it( 'should insert line break at end', async () => {

      at Object.toMatchSnapshot (specs/writing-flow.test.js:172:42)
      at tryCatch (../../node_modules/regenerator-runtime/runtime.js:62:40)
      at Generator.invoke [as _invoke] (../../node_modules/regenerator-runtime/runtime.js:288:22)
      at Generator.prototype.(anonymous function) [as next] (../../node_modules/regenerator-runtime/runtime.js:114:21)
      at asyncGeneratorStep (specs/writing-flow.test.js:9:103)
      at _next (specs/writing-flow.test.js:11:194)

gziolo · 2019-04-29T12:46:12Z

There are still some random failures on Travis.

https://travis-ci.com/WordPress/gutenberg/jobs/196309131#L1085
https://travis-ci.com/WordPress/gutenberg/jobs/196309136#L1084

 FAIL  specs/writing-flow.test.js (17.96s)
● adding blocks › should navigate around inline boundaries
    expect(received).toMatchSnapshot()
    Snapshot name: `adding blocks should navigate around inline boundaries 1`
    - Snapshot
    + Received
      "<!-- wp:paragraph -->
      <p>FirstAfter</p>
      <!-- /wp:paragraph -->
      
      <!-- wp:paragraph -->
    - <p>Before<strong>InsideSecondInside</strong>After</p>
    + <p>BeforeInsideSecondInsideAfter</p>
      <!-- /wp:paragraph -->
      
      <!-- wp:paragraph -->
      <p>BeforeThird</p>
      <!-- /wp:paragraph -->"
      129 | 		await page.keyboard.type( 'Before' );
      130 | 
    > 131 | 		expect( await getEditedPostContent() ).toMatchSnapshot();
          | 		                                       ^
      132 | 	} );
      133 | 
      134 | 	it( 'should navigate around nested inline boundaries', async () => {
      at Object.toMatchSnapshot (specs/writing-flow.test.js:131:42)
      at tryCatch (../../node_modules/regenerator-runtime/runtime.js:62:40)
      at Generator.invoke [as _invoke] (../../node_modules/regenerator-runtime/runtime.js:288:22)
      at Generator.prototype.(anonymous function) [as next] (../../node_modules/regenerator-runtime/runtime.js:114:21)
      at asyncGeneratorStep (specs/writing-flow.test.js:9:103)
      at _next (specs/writing-flow.test.js:11:194)
  ● adding blocks › should navigate around nested inline boundaries
    expect(received).toMatchSnapshot()
    Snapshot name: `adding blocks should navigate around nested inline boundaries 1`
    - Snapshot
    + Received
      "<!-- wp:paragraph -->
    - <p><strong><em>1</em> <em>2</em></strong></p>
    + <p><strong><em>1</em> 2</strong></p>
      <!-- /wp:paragraph -->"
      148 | 		await page.keyboard.press( 'ArrowLeft' );
      149 | 
    > 150 | 		expect( await getEditedPostContent() ).toMatchSnapshot();
          | 		                                       ^
      151 | 
      152 | 		await page.keyboard.type( 'a' );
      153 | 		await page.keyboard.press( 'ArrowRight' );
      at Object.toMatchSnapshot (specs/writing-flow.test.js:150:42)
      at tryCatch (../../node_modules/regenerator-runtime/runtime.js:62:40)
      at Generator.invoke [as _invoke] (../../node_modules/regenerator-runtime/runtime.js:288:22)
      at Generator.prototype.(anonymous function) [as next] (../../node_modules/regenerator-runtime/runtime.js:114:21)
      at asyncGeneratorStep (specs/writing-flow.test.js:9:103)
      at _next (specs/writing-flow.test.js:11:194)
  ● adding blocks › should navigate around nested inline boundaries
    expect(received).toMatchSnapshot()
    Snapshot name: `adding blocks should navigate around nested inline boundaries 2`
    - Snapshot
    + Received
      "<!-- wp:paragraph -->
    - <p>a<strong>b<em>c1d</em>e f<em>g2h</em>i</strong>j</p>
    + <p>a<strong>b<em>c1d</em>e f2g</strong>hij</p>
      <!-- /wp:paragraph -->"
      170 | 		await page.keyboard.type( 'j' );
      171 | 
    > 172 | 		expect( await getEditedPostContent() ).toMatchSnapshot();
          | 		                                       ^
      173 | 	} );
      174 | 
      175 | 	it( 'should insert line break at end', async () => {
      at Object.toMatchSnapshot (specs/writing-flow.test.js:172:42)
      at tryCatch (../../node_modules/regenerator-runtime/runtime.js:62:40)
      at Generator.invoke [as _invoke] (../../node_modules/regenerator-runtime/runtime.js:288:22)
      at Generator.prototype.(anonymous function) [as next] (../../node_modules/regenerator-runtime/runtime.js:114:21)
      at asyncGeneratorStep (specs/writing-flow.test.js:9:103)
      at _next (specs/writing-flow.test.js:11:194)

https://travis-ci.com/WordPress/gutenberg/jobs/196309137#L1083

 ● List › should outdent with children
    expect(received).toMatchSnapshot()
    Snapshot name: `List should outdent with children 2`
    - Snapshot
    + Received
      "<!-- wp:list -->
    - <ul><li>a</li><li>b<ul><li>c</li></ul></li></ul>
    + <ul><li>a<ul><li>b</li><li>c</li></ul></li></ul>
      <!-- /wp:list -->"
      294 | 		await pressKeyWithModifier( 'primaryShift', 'm' );
      295 | 
    > 296 | 		expect( await getEditedPostContent() ).toMatchSnapshot();
          | 		                                       ^
      297 | 	} );
      298 | 
      299 | 	it( 'should insert a line break on shift+enter', async () => {
      at Object.toMatchSnapshot (specs/blocks/list.test.js:296:42)
      at tryCatch (../../node_modules/regenerator-runtime/runtime.js:62:40)
      at Generator.invoke [as _invoke] (../../node_modules/regenerator-runtime/runtime.js:288:22)
      at Generator.prototype.(anonymous function) [as next] (../../node_modules/regenerator-runtime/runtime.js:114:21)
      at asyncGeneratorStep (specs/blocks/list.test.js:9:103)
      at _next (specs/blocks/list.test.js:11:194)

gziolo · 2019-04-29T13:02:55Z

https://travis-ci.com/WordPress/gutenberg/jobs/196309137#L1114

FAIL packages/e2e-tests/specs/block-hierarchy-navigation.test.js (9.319s)
  ● Navigating the block hierarchy › should navigate block hierarchy using only the keyboard
    expect(received).toMatchSnapshot()
    Snapshot name: `Navigating the block hierarchy should navigate block hierarchy using only the keyboard 1`
    - Snapshot
    + Received
    - "<!-- wp:columns {"columns":3} -->
    - <div class="wp-block-columns has-3-columns"><!-- wp:column -->
    + "<!-- wp:columns -->
    + <div class="wp-block-columns has-2-columns"><!-- wp:column -->
      <div class="wp-block-column"><!-- wp:paragraph -->
      <p>First column</p>
    + <!-- /wp:paragraph -->
    + 
    + <!-- wp:paragraph -->
    + <p></p>
      <!-- /wp:paragraph --></div>
      <!-- /wp:column -->
      
      <!-- wp:column -->
      <div class="wp-block-column"></div>
    - <!-- /wp:column -->
    - 
    - <!-- wp:column -->
    - <div class="wp-block-column"><!-- wp:paragraph -->
    - <p>Third column</p>
    - <!-- /wp:paragraph --></div>
      <!-- /wp:column --></div>
      <!-- /wp:columns -->"
      80 | 		await page.keyboard.type( 'Third column' );
      81 | 
    > 82 | 		expect( await getEditedPostContent() ).toMatchSnapshot();
         | 		                                       ^
      83 | 	} );
      84 | 
      85 | 	it( 'should appear and function even without nested blocks', async () => {
      at Object.toMatchSnapshot (specs/block-hierarchy-navigation.test.js:82:42)
      at tryCatch (../../node_modules/regenerator-runtime/runtime.js:62:40)
      at Generator.invoke [as _invoke] (../../node_modules/regenerator-runtime/runtime.js:288:22)
      at Generator.prototype.(anonymous function) [as next] (../../node_modules/regenerator-runtime/runtime.js:114:21)
      at asyncGeneratorStep (specs/block-hierarchy-navigation.test.js:9:103)
      at _next (specs/block-hierarchy-navigation.test.js:11:194)

gziolo · 2019-04-29T14:24:20Z

This is what I have locally when I run npm run test-e2e:

Test Suites: 1 skipped, 69 passed, 69 of 70 total
Tests:       10 skipped, 376 passed, 386 total
Snapshots:   251 passed, 251 total
Time:        572.662s
Ran all test suites.

There are still some tests failing on Travis. All of them around applying formats, so there might be some issue in Chrome 75. /cc @ellatrix

This is what I try now locally:

for i in {1..20}; do npx wp-scripts test-e2e --config packages/e2e-tests/jest.config.js packages/e2e-tests/specs/writing-flow.test.js; done;

It has failed 10 out of 20 times on one or both of the following tests:

should navigate around inline boundaries (2105ms)
should navigate around nested inline boundaries (1242ms)

…avigation seems to behave differently. Simplifying and waiting for a selector seems to resolve the issue

…esent in DOM

…a selector

gziolo · 2019-08-05T17:58:36Z

It looks like @ellatrix found a way to fix failing tests in #16875. We will close this PR as soon as the other one is ready to go 🎉

gziolo added [Status] In Progress Tracking issues with work in progress [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. labels Apr 15, 2019

gziolo requested review from aduth, ajitbohra, mkaz, nerrad, oandregal, ntwb, talldan and youknowriad as code owners April 15, 2019 14:32

gziolo self-assigned this Apr 15, 2019

talldan force-pushed the update/puppeteer-bump branch from b44e60b to 5e0a0e7 Compare April 16, 2019 07:42

talldan mentioned this pull request Apr 16, 2019

Avoid synchronous xhr by using window.sendBeacon when available #14994

Merged

5 tasks

gziolo force-pushed the update/puppeteer-bump branch from 5e0a0e7 to 804880c Compare April 23, 2019 16:44

gziolo force-pushed the update/puppeteer-bump branch from 4cfb304 to 2adf348 Compare April 27, 2019 12:27

gziolo force-pushed the update/puppeteer-bump branch from dbc196f to 10153f0 Compare April 29, 2019 12:30

gziolo force-pushed the update/puppeteer-bump branch from 10153f0 to aa4f816 Compare April 29, 2019 13:59

gziolo added [Type] Task Issues or PRs that have been broken down into an individual action to take and removed [Status] In Progress Tracking issues with work in progress labels Apr 29, 2019

gziolo force-pushed the update/puppeteer-bump branch from 3fd75b3 to 2632657 Compare June 11, 2019 05:49

gziolo added the [Status] Blocked Used to indicate that a current effort isn't able to move forward label Jun 18, 2019

gziolo and others added 17 commits July 9, 2019 12:16

Upgrade Puppeteer to the latest version

fa568f8

Fix waitForPreviewNavigation in newer versions of puppeteer. waitForN…

6c12de9

…avigation seems to behave differently. Simplifying and waiting for a selector seems to resolve the issue

Update demo test to make it work with Vimeo mock

71dc719

Ensure that editor metabox plugin test waits for the element to be pr…

fa91cc9

…esent in DOM

Improve reliability of RichText tests

e741f29

Tests: Update Puppeteer version to the latest one

815192c

Docs: Update changelog for @worpress/scripts package

a5b3510

Tests: Refactor pressKeyTimes to use for loop for simplicity

2b0e636

Ensure createNewPost waits until blocks are rendered

79cfc60

Try to fix failing links e2e tests by waiting before trying to click …

c07db72

…a selector

Skip unreliable tests which fail on Travis

df375de

Wild idea to slow down Travis to make tests fail more consistently :)

4c4b888

Skip all failing tests to move forward with Puppeteer upgrade

2e19e50

Bring back @return in pressKeyTimes JSDoc section

eec92b3

Upgrade Puppeteer to v1.16 with Chromium v76

2031d27

Bump Puppeteer to version 1.17.0

0f349c9

Try earlier selection detection

2550add

ellatrix force-pushed the update/puppeteer-bump branch from 2632657 to 2550add Compare July 9, 2019 10:22

gziolo requested review from daniloercoli, etoledom, jorgefilipecosta and SergioEstevao as code owners July 9, 2019 10:22

ellatrix mentioned this pull request Aug 5, 2019

Upgrade Puppeteer to the latest version (1.19.0) #16875

Merged

5 tasks

gziolo added [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed and removed [Status] Blocked Used to indicate that a current effort isn't able to move forward labels Aug 6, 2019

gziolo closed this in #16875 Aug 7, 2019

gziolo deleted the update/puppeteer-bump branch August 7, 2019 06:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade Puppeteer to the latest version #14986

Upgrade Puppeteer to the latest version #14986

gziolo commented Apr 15, 2019 •

edited

Loading

gziolo commented Apr 15, 2019

talldan commented Apr 16, 2019 •

edited

Loading

talldan commented Apr 16, 2019 •

edited

Loading

gziolo commented Apr 16, 2019

gziolo commented Apr 23, 2019

gziolo commented Apr 24, 2019

gziolo commented Apr 27, 2019

gziolo commented Apr 27, 2019 •

edited

Loading

gziolo commented Apr 29, 2019 •

edited

Loading

gziolo commented Apr 29, 2019

gziolo commented Apr 29, 2019

gziolo commented Aug 5, 2019

Upgrade Puppeteer to the latest version #14986

Upgrade Puppeteer to the latest version #14986

Conversation

gziolo commented Apr 15, 2019 • edited Loading

Description

Disabled tests

Testing

gziolo commented Apr 15, 2019

talldan commented Apr 16, 2019 • edited Loading

talldan commented Apr 16, 2019 • edited Loading

gziolo commented Apr 16, 2019

gziolo commented Apr 23, 2019

gziolo commented Apr 24, 2019

gziolo commented Apr 27, 2019

gziolo commented Apr 27, 2019 • edited Loading

gziolo commented Apr 29, 2019 • edited Loading

gziolo commented Apr 29, 2019

gziolo commented Apr 29, 2019

gziolo commented Aug 5, 2019

gziolo commented Apr 15, 2019 •

edited

Loading

talldan commented Apr 16, 2019 •

edited

Loading

talldan commented Apr 16, 2019 •

edited

Loading

gziolo commented Apr 27, 2019 •

edited

Loading

gziolo commented Apr 29, 2019 •

edited

Loading