Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block library: Extract deprecated field to their own files (p.2) #15071

Merged
merged 1 commit into from
May 21, 2019
Merged

Block library: Extract deprecated field to their own files (p.2) #15071

merged 1 commit into from
May 21, 2019

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Apr 19, 2019

Description

Part of aligning block library to Block Registration API RFC #13693.

It's all about moving deprecated fields to their own file to follow the proposal drafted in RFC.

Updated blocks:

  • Paragraph
  • Pullquote
  • Quote

How has this been tested?

npm test
npm run test-e2e

Manually tested whether all blocks load as before.

@gziolo gziolo added [Type] Task Issues or PRs that have been broken down into an individual action to take [Package] Block library /packages/block-library [Feature] Block Directory Related to the Block Directory, a repository of block plugins labels Apr 19, 2019
@gziolo gziolo self-assigned this Apr 19, 2019
@youknowriad youknowriad mentioned this pull request Apr 19, 2019
Merged
@gziolo gziolo force-pushed the update/block-library-deprecated-2 branch from e717ecb to 9e6ed25 Compare April 23, 2019 16:42
@gziolo
Copy link
Member Author

gziolo commented May 7, 2019

Blocked by #15268.

@gziolo gziolo added the [Status] Blocked Used to indicate that a current effort isn't able to move forward label May 7, 2019
@gziolo gziolo force-pushed the update/block-library-deprecated-2 branch from 9e6ed25 to 30d5642 Compare May 9, 2019 13:02
@gziolo gziolo removed the [Status] Blocked Used to indicate that a current effort isn't able to move forward label May 9, 2019
@gziolo gziolo force-pushed the update/block-library-deprecated-2 branch from 30d5642 to 8fa1405 Compare May 16, 2019 13:27
@gziolo
Copy link
Member Author

gziolo commented May 16, 2019

It's ready for review after integration tests were added in #15268.

@gziolo gziolo added the Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code label May 16, 2019
@gziolo gziolo merged commit 9e6c041 into master May 21, 2019
@gziolo gziolo deleted the update/block-library-deprecated-2 branch May 21, 2019 11:50
@gziolo gziolo added this to the 5.8 (Gutenberg) milestone May 21, 2019
@gziolo gziolo mentioned this pull request Jun 18, 2019
Closed
14 tasks
This was referenced Oct 16, 2024
Open
Open
This was referenced Oct 16, 2024
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@noisysocks noisysocks Awaiting requested review from noisysocks

@notnownikki notnownikki Awaiting requested review from notnownikki

@Soean Soean Awaiting requested review from Soean

@talldan talldan Awaiting requested review from talldan

Assignees

@gziolo gziolo

Labels
[Feature] Block Directory Related to the Block Directory, a repository of block plugins Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code [Package] Block library /packages/block-library [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
5.8 (Gutenberg)
Development

Successfully merging this pull request may close these issues.
2 participants
@gziolo @youknowriad