Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve label for multiple additional css classes #15634

Merged
merged 2 commits into from
May 15, 2019

Conversation

mkaz
Copy link
Member

@mkaz mkaz commented May 14, 2019

Description

Add clarity around additional css classes so users know that multiple
classes are supported and the proper separator between classes.

Fixes #15597

How has this been tested?

Confirm change shows as expected, includes i18n
Uses standard controls

Screenshots

Types of changes

  • Add "(es)" so new label is "Additional CSS Class(es)"

  • Add help attribute with help message: "Space separate multiple classes."

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.

Add clarity around additional css classes so users know that multiple
classes are supported and the proper separator between classes.

* Add "(es)" so new label is "Additional CSS Class(es)"

* Add help attribute with help message: "Space separate multiple classes."
@gziolo gziolo added [Feature] Blocks Overall functionality of blocks [Type] Copy Issues or PRs that need copy editing assistance labels May 15, 2019
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someone could double check the copy but I personally agree with the change 👍

@youknowriad youknowriad added the Needs Copy Review Needs review of user-facing copy (language, phrasing) label May 15, 2019
@michelleweber
Copy link

I'd probably go with "Separate multiple classes with spaces" or "When adding multiple classes, put a space between each one" to be a little more readable/clear.

@mkaz
Copy link
Member Author

mkaz commented May 15, 2019

Thanks @michelleweber I've updated using the shorter version due to space where it is displayed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Type] Copy Issues or PRs that need copy editing assistance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve label name for "Additional CSS Class"
4 participants