-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #15652 #15736
Fix issue #15652 #15736
Conversation
b6e44d5
to
55edd94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @miguelfeliciovieira, thank you for fixing this issue.
The code change makes sense to me and seems to fix the problem 👍
After making some additional tests I noticed it become impossible to get the minutes field empty because the 0 was always being added, to improve that I added a very simple commit 55edd94 that kept your change but added a check for the empty case.
Congratulations on your first contribution to Gutenberg 🥇
55edd94
to
5d72558
Compare
@jorgefilipecosta Can you double-check this to be sure it's worked? It looks as though the fix was applied to master, but I'm still seeing the issue recur when testing from the latest master branch. |
@sarahmonster Could you try testing against the plugin version, since it's now available as of Gutenberg 5.8 ? In my own testing, this appears fixed in master. |
Description
Fix this issue using the approach suggested by @aduth by formatting the minutes value when assigning its state.
Fixes: #15652
Checklist: