Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #15652 #15736

Merged
merged 3 commits into from
May 20, 2019
Merged

Conversation

miguelfeliciovieira
Copy link
Contributor

@miguelfeliciovieira miguelfeliciovieira commented May 20, 2019

Description

Fix this issue using the approach suggested by @aduth by formatting the minutes value when assigning its state.

Fixes: #15652

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@gziolo gziolo added [Package] Components /packages/components [Type] Bug An existing feature does not function as intended Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code labels May 20, 2019
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @miguelfeliciovieira, thank you for fixing this issue.
The code change makes sense to me and seems to fix the problem 👍
After making some additional tests I noticed it become impossible to get the minutes field empty because the 0 was always being added, to improve that I added a very simple commit 55edd94 that kept your change but added a check for the empty case.
Congratulations on your first contribution to Gutenberg 🥇

@jorgefilipecosta jorgefilipecosta merged commit 7320d0d into WordPress:master May 20, 2019
@youknowriad youknowriad added this to the 5.8 (Gutenberg) milestone May 24, 2019
@sarahmonster
Copy link
Member

@jorgefilipecosta Can you double-check this to be sure it's worked? It looks as though the fix was applied to master, but I'm still seeing the issue recur when testing from the latest master branch.

@aduth
Copy link
Member

aduth commented Jun 10, 2019

@jorgefilipecosta Can you double-check this to be sure it's worked? It looks as though the fix was applied to master, but I'm still seeing the issue recur when testing from the latest master branch.

@sarahmonster Could you try testing against the plugin version, since it's now available as of Gutenberg 5.8 ? In my own testing, this appears fixed in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code [Package] Components /packages/components [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datepicker converts :0x minutes to :x, making for confusing output
6 participants