Project Management: Merge lib and REST controllers CODEOWNERS

[aduth]

Previously: #15215

For reasons currently outside my understanding, the *-controller.php CODEOWNERS entry is not correctly matching. For the pull request #15651, which includes the file lib/class-wp-rest-widget-areas-controller.php, it should have been expected that @TimothyBJacobs was assigned as reviewer by code ownership.

gutenberg/.github/CODEOWNERS

Line 86 in 761543e

*-controller.php @youknowriad @gziolo @aduth @timothybjacobs

Reference: https://help.github.com/en/articles/about-code-owners

CODEOWNERS should prefer last-match, and follows gitignore syntax. It's possible the convention here is incorrect, though variations tested locally against git check-ignore don't appear to make any difference. Suggestions welcome here. I suspect it is a matter of either (a) nested directories or (b) wildcard placement.

From the pull request #15651, there are also people not expected to be assigned as code owner reviewers (@noisysocks, @nerrad) based on the files changed. It may be that earlier versions of the branch included revisions to files outside this directory (it was rebased a number of times).

The text "code owners" in the screenshot:

..is linked to:

gutenberg/.github/CODEOWNERS

Line 85 in 761543e

/lib @youknowriad @gziolo @aduth

For this reason, we can assume that at least /lib should be working as expected. Until this can be correctly diagnosed, @TimothyBJacobs has agreed to be included as code owner for /lib.

[noisysocks]

Weird. Is there a way to report this as a bug to GitHub?

[aduth]

Weird. Is there a way to report this as a bug to GitHub?

gitignore syntax has always eluded my understanding, so it may very likely be a failing on my part and not actually a bug 🤷‍♂