-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scripts: Document and simplify changing file entry and output of build scripts #15982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Type] Enhancement
A suggestion for improvement.
[Package] Scripts
/packages/scripts
labels
Jun 4, 2019
gziolo
force-pushed
the
update/custom-file-entry-output
branch
2 times, most recently
from
June 5, 2019 12:14
1279c88
to
682d919
Compare
gziolo
requested review from
aduth,
ajitbohra,
nerrad,
oandregal,
ntwb and
youknowriad
as code owners
June 5, 2019 12:26
youknowriad
approved these changes
Jun 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
gziolo
force-pushed
the
update/custom-file-entry-output
branch
2 times, most recently
from
June 14, 2019 10:42
405163a
to
4ff786e
Compare
gziolo
force-pushed
the
update/custom-file-entry-output
branch
from
June 14, 2019 10:46
4ff786e
to
0d7624a
Compare
daniloercoli
added a commit
that referenced
this pull request
Jun 14, 2019
…rnmobile/open-video-by-browser-for-android * 'master' of https://github.com/WordPress/gutenberg: (34 commits) [RNMobile] Native mobile release v1.7.0 (#16156) Scripts: Document and simplify changing file entry and output of build scripts (#15982) Block library: Refactor Heading block to use class names for text align (#16035) Make calendar block resilient against editor module not being present (#16161) Bump plugin version to 5.9.1 Editor: Fix the issue where statics for deprecated components were not hoisted (#16152) Build Tooling: Use "full" `npm install` for Build Artifacts Travis task (#16166) Scripts: Fix naming conventions for function containing CLI keyword (#16091) Add native support for Inserter (Ported from gutenberg-mobile) (#16114) docs(components/higher-order/with-spoken-messages): fix issue in example code (#16144) docs(components/with-focus-return): fix typo in README.md (#16143) docs(block-editor/components/inspector-controls): fix image path in README.md (#16145) Add mention of on Figma to CONTRIBUTING.md (#16140) Bring greater consistency to placeholder text for media blocks. (#16135) Add descriptive text and a link to embed documentation in embed blocks (#16101) Update toolbar-text.png (#16102) Updating changelogs for the Gutenberg 5.9 packages release chore(release): publish [RNMobile] Fix pasting text on Post Title (#16116) Bump plugin version to 5.9.0 ... # Conflicts: # packages/block-library/src/video/video-player.android.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #14891.
The
build
andstart
commands supports simplified syntax for multiple entry points:In fact, you could call:
as of today to achieve the same but it might take some time to experiment to discover it.
This proposal makes public API less tied to webpack and gives a way to map it to another tool in the future. In addition, it makes it simple to provide entry points by doing all the mapping behind the scenes.
Testing
Two entry points in
src
folder built intobuild
folderCreate two JS files in
src
folder:entry-one.js
entry-two.js
This should output four files:
build/entry-one.js
build/entry-one.deps.json
build/entry-two.js
build/entry-two.deps.json
Custom entry points and custom output folder
Create two JS files in the root folder:
entry-one.js
entry-two.js
This should output four files:
dist/entry-one.js
dist/entry-one.deps.json
dist/entry-two.js
dist/entry-two.deps.json