Removed focus styles, moved outline property #1629

[DevinWalker]

PR Overview

When the user clicked on a tab to insert a block there would be an outline like box-shadow as described in #1629. I have updated the styles to remove this box-shadow.

Before

After

[swissspidy]

Focus style is important for users navigating using the keyboard. Without it, there's no visual indication which element you're currently on.

Instead of this, we should strive to improve the keyboard navigation. See #1606 (comment) for a note on that.

[jasmussen]

Thank you for the PR, and for wanting to contribute!

I agree that visually it's suboptimal to have the glowing blue focus halo. However @swissspidy is right, keyboard navigation requires a good focus style, and we can't remove it like this.

In #904 we are discussing focus styles, how they visually look. This seems the best option to improve the behavior here. There's also an issue with the focus style lingering even when you just click, which is contrary to default system button behavior. The details are here: #904 (comment) — the short of it is, if we can find a properly accessible way of hiding the focus style on mouse click, without affecting keyboard click in any way at all, this could be worth exploring.

[lazharichir]

@swissspidy there is style a focus style, just not the outline

[aduth]

@swissspidy there is style a focus style, just not the outline

I don't think there is though. There's the style applied to the selected tab, but this is different than focus. For example, it should be possible to have "Recent" as selected, but then tab into and focus "Blocks". In which case, the selected styling (background, bottom border) would be applied to "Recent", and the focus styling (outline) would be applied to "Blocks".

(Noting that this keyboard behavior doesn't currently work correctly, but a separate issue from styling. Might fall under #1588)

[jasmussen]

I personally agree that it would be nice if we could find some way to make the focus rectangle not linger after clicking, but that is a separate issue to discuss, and so thank you for the PR, but I'm closing this for now.

I would encourage you all be kind to each other, this PR was very much appreciated, so don't react with thumbs down for people giving us their hard work.