-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Add content alignment options to paragraph block #17577
Merged
mchowning
merged 1 commit into
rnmobile/release-1.16.1
from
rnmobile/1266_add_content_alignment_to_paragraphs
Nov 6, 2019
Merged
[RNMobile] Add content alignment options to paragraph block #17577
mchowning
merged 1 commit into
rnmobile/release-1.16.1
from
rnmobile/1266_add_content_alignment_to_paragraphs
Nov 6, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
1 task
gziolo
added
the
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
label
Sep 26, 2019
mchowning
force-pushed
the
rnmobile/1266_add_content_alignment_to_paragraphs
branch
from
September 27, 2019 16:38
e562a01
to
a6b0e00
Compare
mchowning
force-pushed
the
rnmobile/1266_add_content_alignment_to_paragraphs
branch
from
September 27, 2019 16:41
a6b0e00
to
01a2344
Compare
mchowning
force-pushed
the
rnmobile/1266_add_content_alignment_to_paragraphs
branch
from
October 18, 2019 20:04
01a2344
to
e167910
Compare
mchowning
changed the title
[RNMobile] Add content alignment options to paragraph block
[RNMobile] Add content alignment options to paragraph block on Android
Oct 18, 2019
mchowning
force-pushed
the
rnmobile/1266_add_content_alignment_to_paragraphs
branch
from
October 23, 2019 17:23
20ea4f0
to
6c3526a
Compare
mchowning
changed the title
[RNMobile] Add content alignment options to paragraph block on Android
[RNMobile] Add content alignment options to paragraph block
Oct 23, 2019
1 task
marecar3
approved these changes
Oct 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @mchowning!
LGTM!
mchowning
force-pushed
the
rnmobile/1266_add_content_alignment_to_paragraphs
branch
from
November 5, 2019 19:54
6c3526a
to
23274e6
Compare
mchowning
force-pushed
the
rnmobile/1266_add_content_alignment_to_paragraphs
branch
from
November 6, 2019 18:48
23274e6
to
436dd52
Compare
mchowning
requested review from
adamsilverstein,
aduth,
ajitbohra,
atimmer,
chrisvanpatten,
daniloercoli,
dmsnell,
ellatrix,
etoledom,
gziolo and
jorgefilipecosta
as code owners
November 6, 2019 18:48
mchowning
requested review from
talldan,
TimothyBJacobs and
youknowriad
as code owners
November 6, 2019 18:48
mchowning
changed the base branch from
rnmobile/release/1.16.1
to
rnmobile/release-1.16.1
November 6, 2019 18:50
mchowning
removed request for
mkaz,
karmatosed,
youknowriad,
atimmer,
noisysocks,
mapk,
talldan,
Soean,
gziolo,
ntwb,
ajitbohra,
chrisvanpatten,
mmtr,
nerrad,
aduth,
adamsilverstein,
TimothyBJacobs,
ellatrix,
dmsnell and
jorgefilipecosta
November 6, 2019 18:50
mchowning
deleted the
rnmobile/1266_add_content_alignment_to_paragraphs
branch
November 6, 2019 18:51
mchowning
restored the
rnmobile/1266_add_content_alignment_to_paragraphs
branch
November 6, 2019 19:46
aristath
deleted the
rnmobile/1266_add_content_alignment_to_paragraphs
branch
November 10, 2020 14:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related gutenberg-mobile PR
Description
This PR adds alignment controls for paragraph blocks on mobile, addressing gutenberg-mobile#1266.
How has this been tested?
Checklist: