Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monorepo] import gutenberg-mobile as a package #17950

Closed
wants to merge 4,782 commits into from

Conversation

dratwas
Copy link
Contributor

@dratwas dratwas commented Oct 15, 2019

Description

Explores #11491.
Superseeds #17456 started by @Tug

Wordpress-iOS PR - wordpress-mobile/WordPress-iOS#12762
Wordpress-Android PR - wordpress-mobile/WordPress-Android#10668

This is a migration of gutenberg-mobile to gutenberg repository.

New packages added:

  • @wordpress/react-native-editor - playground react-native app and bundle entrypoint
  • @wordpress/react-native-bridge - module which starts react-native inside the client app (WP-iOS/Android)
  • @wordpress/react-native-aztec - react-native-aztec module

Usual yarn commands ran from gutenberg-mobile are now accessible from gutenberg using npm run native

For instance:

yarn start => npm run native start

How has this been tested?

TBD

Screenshots

Types of changes

Add new native packages, for native build, unifying the 2 repositories

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've imported git history
  • I've checked that the licencing is OK
  • I've checked that package release is working as expected (lerna)
  • I've checked that installing dependencies works as expected and that changes to package-lock.json are OK
  • I've checked that we are up to date with gutenberg-mobile develop branch
  • I've informed concerned developers of the change of repository
  • I've ported e2e tests iOS
  • I've ported e2e tests Android
  • I've ported pre-commit hooks including eslint
  • I've ported i18n
  • I've checked that build scripts are up to date with WordPress-iOS
  • I've checked that build scripts are up to date with WordPress-Android
  • I've checked that WordPress-iOS works properly after migration
  • I've checked that WordPress-Android works properly after migration
  • I've made sure that the project can be opened in Android Studio
  • I've made sure that the project can be opened in XCode
  • I've made sure that the demo app for mobile runs
  • I've made sure that I have excluded any binary files, jar, phar... from the patch (gutenberg-mobile has gradle-wrapper.jar committed to the repo though and we might want to fix that later?)
  • I've checked that all CI steps are imported
  • i've checked that the react-native-aztec example app works

pinarol and others added 30 commits September 5, 2019 21:21
* Enable batch editing on font change

* Remove unnecessary `removeAttribute` call
Merge master (v1.12.0) back to develop
…rg-mobile into add/autosave-monitor

* 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile:
  [iOS]Fix: Oddly formatted text hangs Gutenberg (WordPress#1352)
  Remove redundant bg color within button appender (WordPress#1348)
  Update bundles
  Update package.json version to 1.12.0

# Conflicts:
#	bundle/android/App.js
#	bundle/android/App.js.map
#	bundle/ios/App.js
#	bundle/ios/App.js.map
…monitor

Add "Autosave" bridge methods and enable local auto-save of posts
@Tug Tug self-requested a review October 28, 2019 12:18
webpack.config.js Outdated Show resolved Hide resolved
@dratwas
Copy link
Contributor Author

dratwas commented Oct 30, 2019

MOVED TO #18159 since we can not use a fork with Jitpack build.

@dratwas dratwas closed this Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Build Tooling Issues or PRs related to build tooling [Type] Project Management Meta-issues related to project management of Gutenberg [Type] Technical Prototype Offers a technical exploration into an idea as an example of what's possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.