Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor edit post shortcuts to use the keyboard-shortcuts package #19320

Merged
merged 2 commits into from
Dec 25, 2019

Conversation

youknowriad
Copy link
Contributor

I've also refactored the components that I touched to use useSelect/useDispatch.

I've noticed that the "sidebar toggle" shortcut is not working but that's on master too.

@youknowriad youknowriad merged commit 52000d7 into master Dec 25, 2019
@youknowriad youknowriad deleted the update/edit-post-shortcuts branch December 25, 2019 07:40
Comment on lines +43 to +47
const formattingMethods = {
display: displayShortcut,
raw: rawShortcut,
ariaLabel: shortcutAriaLabel,
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doubt it has much overhead, and I could grant an argument that it benefits from colocation, but this appears to be constant, could be defined at the top of the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants