Fix pass by reference PHP warnings due to PHP 4 compatibility hacks inherited from Core #19404
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #19403 and eliminates a PHP 4.x compatibility fix that causes problems
This fixes a number of PHP warnings. The styles and scripts objects don't need to be passed by reference, that's the default behaviour of objects in PHP 5.0+, the references are only there to avoid object duplication in PHP 4.0 which used pass by value semantics for objects, unlike 5.0 which switched to pass by reference.
How has this been tested?
I made the adjustment locally and the problems went away, no issues were introduced
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: