Apply sentence case formatting to Setting Sidebar controls #19903
Conversation
richtabor
added
[Type] Enhancement
richtabor
requested review from
ajitbohra,
chrisvanpatten,
ellatrix,
jorgefilipecosta,
mkaz,
mkevins,
nerrad,
ntwb,
pinarol,
Soean,
talldan and
youknowriad
as code owners
|
Aside from a possibly-storybook specific question (which applies to a few subsequent changes also) this is a really lovely consistency PR, thank you. CC: @karmatosed — I believe you touched a menu recently, and I think you were moving in the same direction? But here, have a ping regardless. |
|
I am super keen on anything that brings sentence case more consistently throughout, thanks for this @richtabor |
There was a problem hiding this comment.
🚀 from me! Code changes look good + consistent. Great job @richtabor !
|
Anything blocking merge here? can we rebase and land? |
I don't think there is anything blocking - just slipped by. Too bad it didn't make it to G 7.5/WP 5.4 :( |
|
Hi @richtabor 👋 , Thanks for these string changes. I wonder if it may be worth also including similar changes in @iamthomasbishop 👋 , do we want this same change for mobile? We share some of these strings on Gallery block, and I believe we have made some similar changes recently to some strings in |
Great (and timely) question. This came up recently as part of another discussion re: native typography, and here's where I stand on the topic of casing wrt platform standards. My opinion is that we should default to Sentence case (which aligns well with Android), but if possible allow iOS to force Title Case where necessary (titles, buttons, etc). I imagine this would be pretty straight-forward to do with just CSS, but I'm not sure if in our RN project it is that straight-forward, so I'd defer to your best judgment @mkevins. We'd want to apply it programmatically, in a systemized way, so it can scale to the whole UI and be relatively future-proof. An added benefit: y'all devs wouldn't have to even worry about which case to write in 😄 |
jorgefilipecosta
force-pushed
the
try/19902/control-sentence-case
branch
from
9bec6ea
to
827e112
Compare
jorgefilipecosta
added
the
Backport to WP 6.7 Beta/RC
|
Size Change: -7 B (0%) Total Size: 864 kB
ℹ️ View Unchanged
|
|
I rebased and merged this PR so it is included in the next WordPress beta release. I think as follow up we should update the strings on native files. |
jorgefilipecosta
removed
the
Backport to WP 6.7 Beta/RC
Description
This PR closes #19902 by changing existing PanelBody titles to utilize sentence case formatting. Related to #18758, #16764, and #19902.
Screenshots
Types of changes
Text string changes.
Checklist: