Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch code coverage from coveralls to codecov #2054

Merged
merged 2 commits into from
Jul 27, 2017

Conversation

nylen
Copy link
Member

@nylen nylen commented Jul 27, 2017

After a rebase, this should fix the build failures on #2018, #2050, and perhaps others.

Codecov.io looks like a more polished service than coveralls.io, and provides really nice reporting. Example: jestjs/jest#4122 (comment), https://codecov.io/gh/facebook/jest

@codecov-io
Copy link

codecov-io commented Jul 27, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@5321e8b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2054   +/-   ##
=========================================
  Coverage          ?   18.78%           
=========================================
  Files             ?      129           
  Lines             ?     4205           
  Branches          ?      716           
=========================================
  Hits              ?      790           
  Misses            ?     2876           
  Partials          ?      539

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5321e8b...fc2c6a8. Read the comment docs.

@nylen
Copy link
Member Author

nylen commented Jul 27, 2017

For some reason Codecov.io still isn't showing up as one of the "checks passed" :(

I'll merge this for now to fix the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants