Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change wp_make_content_images_responsive to wp_filter_content_tags #21514

Conversation

johnstonphilip
Copy link
Contributor

@johnstonphilip johnstonphilip commented Apr 9, 2020

Fixes #21514

Description

Swapped the call to wp_make_content_images_responsive for Template Parts to wp_filter_content_tags, in-line with the change to the_content in WordPress Core here:
https://core.trac.wordpress.org/changeset/47554

How has this been tested?

  1. Ensure you are on WordPress trunk
  2. Use a Block Based Theme like https://github.com/WordPress/theme-experiments/tree/master/parisienne
  3. Notice you see a notice that wp_make_content_images_responsive is deprecated since 5.5.0.
  4. Switch to branch try/replace_wp_make_content_images_responsive
  5. Notice the notice is now gone.

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

Copy link
Member

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me for now. Thanks!

@talldan talldan added [Type] Task Issues or PRs that have been broken down into an individual action to take Backwards Compatibility Issues or PRs that impact backwards compatability labels Apr 20, 2020
@talldan talldan merged commit fa16fa3 into WordPress:master Apr 20, 2020
@github-actions github-actions bot added this to the Gutenberg 8.0 milestone Apr 20, 2020
@johnstonphilip johnstonphilip deleted the try/replace_wp_make_content_images_responsive branch April 20, 2020 15:05
@ellatrix ellatrix mentioned this pull request Jun 16, 2020
12 tasks
@WordPress WordPress deleted a comment from theconversionguru Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backwards Compatibility Issues or PRs that impact backwards compatability [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants