Make global inserter always visible & Fix a Global inserter bug #22115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
|
Size Change: +32 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
jorgefilipecosta
force-pushed
the
fix/global-inserter-never-shows-on-locked-cpts
branch
from
3d5371c
to
4c2bc98
Compare
jorgefilipecosta
requested review from
ajitbohra,
nerrad,
ntwb and
talldan
as code owners
jorgefilipecosta
force-pushed
the
fix/global-inserter-never-shows-on-locked-cpts
branch
from
4c2bc98
to
fa66dff
Compare
youknowriad
reviewed
May 19, 2020
| hasFixedToolbar: select( 'core/edit-post' ).isFeatureActive( | ||
| 'fixedToolbar' | ||
| ), | ||
| // This setting (richEditingEnabled) should not live in the block editor's setting. | ||
| isInserterEnabled: | ||
| select( 'core/edit-post' ).getEditorMode() === 'visual' && | ||
| select( 'core/editor' ).getEditorSettings().richEditingEnabled, | ||
| isInserterVisible: select( 'core/block-editor' ).hasInserterItems(), | ||
| isInserterVisible: hasInserterItems( |
There was a problem hiding this comment.
Right now we can "disable" or "hide" the inserter, I wonder if we should just one technique in all cases (disable it) to avoid "jumps"
There was a problem hiding this comment.
So essentially you are suggesting a refactor that makes the inserter always visible, although sometimes it can be disabled?
I think it would be a positive change and the UX would be better because the position of the other buttons would not move around and we would be consistent with what happens in other buttons e.g: undo.
There was a problem hiding this comment.
yes, something like that.
jorgefilipecosta
force-pushed
the
fix/global-inserter-never-shows-on-locked-cpts
branch
from
fa66dff
to
263eec7
Compare
|
Hi @youknowriad this PR was updated and now makes the global inserter always visible. |
youknowriad
reviewed
May 21, 2020
|
|
||
| <!-- wp:columns --> | ||
| <div class=\\"wp-block-columns\\"></div> | ||
| <!-- /wp:columns -->" |
There was a problem hiding this comment.
Not sure I understand why the snapshots change since you add a new test?
There was a problem hiding this comment.
I added a columns block to the default template so I can test a CPT locked all with a block without locking. The existing snapshots need to be updated to contain the added columns block.
youknowriad
approved these changes
May 21, 2020
jorgefilipecosta
force-pushed
the
fix/global-inserter-never-shows-on-locked-cpts
branch
from
263eec7
to
8245ee8
Compare
jorgefilipecosta
changed the title
jorgefilipecosta
deleted the
fix/global-inserter-never-shows-on-locked-cpts
branch
12 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The global inserter never appears if inserting at the root level is not possible. Inserting at the root level may not be possible, while inserting inside a specific block may be possible e.g: if we have CPT with locking all and the columns block inside.
This PR addresses the issue and makes sure the global inserter appears if it is possible to insert a block in the current position where it will be inserted.
How has this been tested?
I added an end to end tests and verified it passes.