-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit Site: Page and Template switchers improvements. #22449
Edit Site: Page and Template switchers improvements. #22449
Conversation
Size Change: +67 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
Is this |
I guess it isn't then. I copied the approach for taxonomies that I think @youknowriad took. |
I thought preloading at |
|
Right, but my point was that if you preload |
Can we change the order? |
I'm not sure, the preloading middleware gets initialized with a In my mind, |
@youknowriad What do you think? |
That makes sense to me, and I don't see any problems straight away. |
Ideally, we remove For the middlewares order, I don't really know, we can try but changing the order can be impactful. |
It's still under a11y review.
👍 Let's try it on another PR. |
d42c354
to
5ae3a7c
Compare
5ae3a7c
to
22cc8dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice improvement for now :) I think the UX is still confusing in this area because it's not clear how pages & templates relate to each other. (Especially since you'd never really try to render "example page" with the "category template".) I bet that will be resolved as we iterate further on design, and as we get better controls for assigning a template to a page.
I definitely agree with this, since it would be a pretty bad UX to have all pages showing in the dropdown at once if a site has hundreds of them! (Could see search being useful here too) |
I'm working on something like that now. |
Description
This PR improves a few things related to the page and template switchers:
How has this been tested?
It was verified that the page and template switchers still work as expected.
Screenshots
Checklist: