Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try hiding block toolbar under ellipsis #2248

Closed
wants to merge 1 commit into from

Conversation

ellatrix
Copy link
Member

@ellatrix ellatrix commented Aug 6, 2017

This is an alternative to #2148 and tries to address the blocky feel/noisy UI feedback.

I'm not proposing to merge this, it's just a proof of concept.

Think of it a bit as the right-click of Gutenberg.

Here are the states:

  • Hover and select. We could still trim down the hover state if needed, or just design it better.

screenshot 2017-08-06 16 03 49

  • Revealed toolbar state. Maybe I'd also move the right icons under the toolbar for a cleaner look.

screenshot 2017-08-06 16 04 47

  • Typing state. Moving the mouse brings you back to the selected state, which happens to be the same as hover. :)

screenshot 2017-08-06 16 06 26

  • Text selection state. Selecting some usually text implies a formatting action, so we should show the toolbar. It hides again when you remove the selection.

screenshot 2017-08-06 16 08 15

Things I like about this:

  • Keyboard users are less likely to need the UI, so it's not there.
  • When you're in the process of writing, you don't really need the toolbar. You only need it for editing (usually after you're done writing). So when you click around while writing (non heavy keyboard users), the toolbar doesn't pop in your face all the time. If you move the mouse, it's the same state as hover.
  • When you are in an editing flow and need to move around text, format it, etc., you don't really need any more clicks. You can open the toolbar immediately from hovering the block. Formatting options become available as soon as you select some text, if you're a heavy mouse user.

Things I don't like about this:

  • Hover state still feel strange to me, in general. Maybe it just needs a better design.

Maybe we need block setting for "object-like" blocks such as images. There it would make sense to show the toolbar all the time, though I don't mind it when I think about it as right-click for Gutenberg. It makes it feel less heavy overall.

@ellatrix ellatrix added the Design label Aug 6, 2017
@WordPress WordPress deleted a comment from codecov bot Aug 6, 2017
@WordPress WordPress deleted a comment from codecov bot Aug 6, 2017
@jasmussen
Copy link
Contributor

While I do love how this looks, I'm not convinced that it's a good solution. It hides a lot of important stuff behind a small touch target, and adds friction. While not as good looking or contextual, I think the fixed toolbar (#2148) is a better "plan b" if we can't get the current system to feel lightweight enough.

@ellatrix
Copy link
Member Author

ellatrix commented Aug 7, 2017 via email

@jasmussen
Copy link
Contributor

Sure. Right now you click the block itself to surface the quick toolbar. This is a big and easy touch target. Although I love the visual minimalism of the little ellipsis, it's a smaller touch target.

@ellatrix
Copy link
Member Author

ellatrix commented Aug 7, 2017

If the touch target is too small, we could always make it bigger.

Anyway, it was worth a try. :)

@jasmussen
Copy link
Contributor

No exploration is wasted. Everything becomes part of the whole picture. If an avenue was explored and abandoned, it's an avenue cauterized, and intentionally not chosen. That has great value too.

Copy link
Contributor

@melchoyce melchoyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I think this is a cool exploration, I agree with @jasmussen.

@ellatrix ellatrix closed this Aug 24, 2017
@ellatrix ellatrix deleted the try/toggle-block-toolbar branch August 24, 2017 20:00
ceyhun pushed a commit that referenced this pull request Jun 17, 2020
Retrieve react native version from package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants