Trigger additional widget setup actions #22807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
jorgefilipecosta
deleted the
update/trigger-additional-widget-setup-actions
branch
12 tasks
tyxla
added a commit
to Automattic/jetpack
that referenced
this pull request
Oct 8, 2020
Currently, on `widget_admin_setup`, in the Widget Visibility module we'll run heavy operations to retrieve a bunch of entities, but we only really use those on the widgets page. Among those entities include all pages, categories, tags, custom taxonomy terms, all registered post types, users. For sites that don't leverage cache and have many pages with a lot of content, this can cause significant delays in TTFB and even end up in OOM errors. The reason for this is that since Gutenberg 8.3 we'll call the `widget_admin_setup` hook on the block editor, too (see WordPress/gutenberg#22807), but never actually use this data in the block editor. This means that we can disable the heavy logic on the block editor pages. This is what this PR does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #22765.
Some widgets don't enqueue their scripts using "admin_print_scripts-widgets.php" action and use other actions like "sidebar_admin_setup".
This makes these widgets not work as expected on the legacy widgets block.
This PR improves the "emulation" of the widgets screen for these cases.
How has this been tested?
I installed these two plugins https://wordpress.org/plugins/simple-image-widget/, http://wordpress.org/plugins/image-widget/.
I created a new post I added the legacy widgets block.
I selected each of the widgets and verified both of them work as expected. On master they do not work.