Buttons block: remove block alignment options #23133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +32 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
ZebulanStanphill
force-pushed
the
remove/buttons-block-align
branch
from
bb7cca2
to
80c3a39
Compare
gziolo
reviewed
Jun 14, 2020
|
I will just add in this issue, as I believe it might have some relevance: #21509 |
ZebulanStanphill
force-pushed
the
remove/buttons-block-align
branch
4 times, most recently
from
0e3eb79
to
384ca61
Compare
ZebulanStanphill
force-pushed
the
remove/buttons-block-align
branch
from
384ca61
to
5174a52
Compare
ZebulanStanphill
changed the title
6 tasks
|
Upon further exploration, I have discovered that it would be best to add the proper alignment/justification controls at the same time as removing the broken/confusing ones, and thus reduce the number of deprecations created. I'm closing this in favor of #23168. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed here, the Buttons block probably shouldn't have the left/center/right block "alignment" options. They aren't really useful and they don't do what you might expect them to. The Buttons block should instead have item justification/alignment options (similar to the Navigation block).
This PR takes the first step by removing the current block "alignment" options, since I think they lack usefulness and are confusing in behavior. It also updates the "Two Buttons" block pattern to not use the option; in a future PR when the Buttons block gets item alignment options, the block pattern could be updated to use that to center the buttons instead.
How has this been tested?
I copied some aligned Buttons blocks from a website running Gutenberg 8.3.0 into an instance of the editor running this branch to ensure that the removal of the alignment support is handled properly. The old blocks with
alignxxxclasses have theiralignattribute removed, but the class name is retained in the custom class name field, as expected.Checklist: