Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gallery block: convert gallery to a wrapper around the core image block #24039

Closed
wants to merge 20 commits into from
Closed

Gallery block: convert gallery to a wrapper around the core image block #24039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
e54f7e5
fix conflicts
Oct 7, 2020
d0fec85
fix conflict
Oct 7, 2020
ac33272
Fix bind to missing method
Jul 21, 2020
059dd22
remove redundant code
Jul 21, 2020
a929753
use replaceInnerBlocks to prevent duplication of images
Jul 21, 2020
34c690b
Some more tidy up
Jul 21, 2020
d7c83f5
fix conflict
Oct 7, 2020
d45fec8
Use block context to pass down options to disable resize and align
Jul 22, 2020
7db7c0e
fix conflict
Oct 7, 2020
8868cc7
fix conflict
Oct 7, 2020
946b5df
fix cnflict
Oct 7, 2020
2131eb9
Fix context namespacing
Jul 22, 2020
319bb73
Fix broken css selector nesting
Jul 26, 2020
f84f417
Fix conflict
Oct 7, 2020
7789036
fix conflicts
Oct 7, 2020
6d7df5f
conflicts
Oct 7, 2020
2399c05
add child wrapper callback to InnerBlocks.Content in save method
Aug 18, 2020
8a600fe
remove unneeded fragments
Aug 19, 2020
11a028c
Fix classname
Aug 21, 2020
adaee2c
Fix error with defaultColumnsNumber when attributes.ids is not set
Sep 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 16 additions & 44 deletions packages/block-library/src/gallery/block.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,50 +2,6 @@
"name": "core/gallery",
"category": "media",
"attributes": {
"images": {
"type": "array",
"default": [],
"source": "query",
"selector": ".blocks-gallery-item",
"query": {
"url": {
"type": "string",
"source": "attribute",
"selector": "img",
"attribute": "src"
},
"fullUrl": {
"type": "string",
"source": "attribute",
"selector": "img",
"attribute": "data-full-url"
},
"link": {
"type": "string",
"source": "attribute",
"selector": "img",
"attribute": "data-link"
},
"alt": {
"type": "string",
"source": "attribute",
"selector": "img",
"attribute": "alt",
"default": ""
},
"id": {
"type": "string",
"source": "attribute",
"selector": "img",
"attribute": "data-id"
},
"caption": {
"type": "string",
"source": "html",
"selector": ".blocks-gallery-item__caption"
}
}
},
"ids": {
"type": "array",
"items": {
Expand Down Expand Up @@ -73,8 +29,24 @@
"sizeSlug": {
"type": "string",
"default": "large"
},
"allowBlockAlign": {
"type": "boolean",
"default": false
},
"allowResize": {
"type": "boolean",
"default": false
},
"isList": {
"type": "boolean",
"default": true
}
},
"providesContext": {
"allowBlockAlign": "allowBlockAlign",
"allowResize": "allowResize"
},
"supports": {
"anchor": true,
"align": true
Expand Down
Loading