Remove autoFocus prop from URLInput and from the inserter search form #27578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
requested review from
adamziel,
ajitbohra,
draganescu,
ellatrix,
kevin940726,
noisysocks,
talldan and
tellthemachines
as code owners
youknowriad
added
[Focus] Accessibility (a11y)
|
Size Change: +1 B Total Size: 1.21 MB
ℹ️ View Unchanged
|
youknowriad
requested review from
cameronvoell,
guarani,
nerrad and
ntwb
as code owners
youknowriad
force-pushed
the
remove/auto-focus
branch
from
ca912bc
to
68d78e3
Compare
|
The tests are good and I believe they cover most cases. I'm going to land this refactor. (12 code owners and no single comment, there's definitely an issue with the code owners feature) |
youknowriad
removed
the
Needs Dev Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #27574
In several places in our codebase, we were using auto-focus as an escape hack to the lack of focusOnMount behavior in the right components (popovers, modals...).
As suggested by the eslint rule, this prop should be avoided as much as possible. This PR tries to get rid of it from the URLInput component and from the Inserter Search Form