Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve image drop zone contrast ratio #2767

Merged
merged 2 commits into from
Sep 25, 2017

Conversation

Rahmon
Copy link
Contributor

@Rahmon Rahmon commented Sep 22, 2017

Change the color from white to dark gray ($dark-gray-700). Now the color constrast ratio is 6.16:1.

#2134

screen shot 2017-09-22 at 10 35 31

@Rahmon Rahmon changed the title Improve image drop zone contrast ratio #2134 Improve image drop zone contrast ratio Sep 22, 2017
@aduth aduth added the Needs Design Feedback Needs general design feedback. label Sep 22, 2017
@karmatosed
Copy link
Member

I think a better approach would be darken the blue and keep the icon white. Can you try that please?

@karmatosed karmatosed added Needs Design Needs design efforts. and removed Needs Design Feedback Needs general design feedback. labels Sep 24, 2017
@Rahmon
Copy link
Contributor Author

Rahmon commented Sep 25, 2017

Change background to dark blue:

dropzone-gutenberg

@codecov
Copy link

codecov bot commented Sep 25, 2017

Codecov Report

Merging #2767 into master will decrease coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2767      +/-   ##
==========================================
- Coverage   33.69%   33.42%   -0.27%     
==========================================
  Files         185      188       +3     
  Lines        5594     5639      +45     
  Branches      976      981       +5     
==========================================
  Hits         1885     1885              
- Misses       3141     3181      +40     
- Partials      568      573       +5
Impacted Files Coverage Δ
editor/modes/visual-editor/index.js 0% <0%> (ø) ⬆️
editor/sidebar/table-of-contents/index.js
editor/sidebar/table-of-contents/item.js
editor/word-count/index.js 0% <0%> (ø)
editor/document-outline/item.js 0% <0%> (ø)
editor/document-outline/index.js 0% <0%> (ø)
editor/sidebar/document-outline-panel/index.js 0% <0%> (ø)
editor/table-of-contents/index.js 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26369c3...7974361. Read the comment docs.

@karmatosed
Copy link
Member

Looks good to me, thanks for doing that change. I'll merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Needs design efforts.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants