Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gallery block fixtures to match with gallery refactor to nested Image Blocks #28481

Closed
wants to merge 86 commits into from
Closed

Update gallery block fixtures to match with gallery refactor to nested Image Blocks #28481

wants to merge 86 commits into from

Commits on Feb 10, 2021

  1. Update Gallery to nested image blocks

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    9f148d9 View commit details
    Browse the repository at this point in the history

  2. Fix issue with images not loading on first selection from media gallery

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    7fa1397 View commit details
    Browse the repository at this point in the history

  3. Remove the default columns setting as we don't have access to innerBl… 

    …ocks at the point that the block validation is run
    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    4dbf48f View commit details
    Browse the repository at this point in the history

  4. Revert "Remove the default columns setting as we don't have access to… 

    … innerBlocks at the point that the block validation is run"

This reverts commit 4d95e95.
    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    9d21319 View commit details
    Browse the repository at this point in the history

  5. Add image count so we can work out default columns as innerBlocks not… 

    … available at point of block validation
    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    fe7a91b View commit details
    Browse the repository at this point in the history

  6. Disable the innerBlocks dropzones so drag drop works same as existing… 

    … gallery - with the idea that we will improve the innerblocks drag and drop in a later PR
    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    849f82b View commit details
    Browse the repository at this point in the history

  7. Lint changes

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    4553dc2 View commit details
    Browse the repository at this point in the history

  8. Revert "Lint changes" 

    This reverts commit 9b0abcc.
    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    500b988 View commit details
    Browse the repository at this point in the history

  9. Revert "Disable the innerBlocks dropzones so drag drop works same as … 

    …existing gallery - with the idea that we will improve the innerblocks drag and drop in a later PR"

This reverts commit cc05d60.
    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    540bbbd View commit details
    Browse the repository at this point in the history

  10. Suggested solution for handling multiple file drop into gallery

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    4a13c9d View commit details
    Browse the repository at this point in the history

  11. Remove non image files from drag and drop and disable individual imag… 

    …e drop zone
    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    bf5f8d9 View commit details
    Browse the repository at this point in the history

  12. Fix transform to individual images

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    f896da9 View commit details
    Browse the repository at this point in the history

  13. Fix transform from individual images

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    bd06610 View commit details
    Browse the repository at this point in the history

  14. Revert drag and drop transform changes

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    2dd4930 View commit details
    Browse the repository at this point in the history

  15. Add gallery transform to image block to override the default gallery … 

    …transform when dragging multiple images onto the gallery
    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    57b7d98 View commit details
    Browse the repository at this point in the history

  16. Move handling of file uploads to Gallery from media placeholder

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    990cfb9 View commit details
    Browse the repository at this point in the history

  17. split innerblocks mapping into separate effect to reduce chatter

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    689d7bc View commit details
    Browse the repository at this point in the history

  18. Add useMemo to currentImageOptions

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    c360f72 View commit details
    Browse the repository at this point in the history

  19. reuse existing innerBlocks rather than recreating with every new imag… 

    …e selection
    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    9509366 View commit details
    Browse the repository at this point in the history

  20. Switch to useMemo for updating local image const instead of local com… 

    …ponent state
    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    570c702 View commit details
    Browse the repository at this point in the history

  21. Fix issue with image sizing not being available on initial load of co… 

    …mponent some times
    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    be26af8 View commit details
    Browse the repository at this point in the history

  22. Memoise the useImageSizes hook

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    d152935 View commit details
    Browse the repository at this point in the history

  23. Fix issue with media browser defaulting to edit gallery view

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    719b76b View commit details
    Browse the repository at this point in the history

  24. Fix missed incorrect use of addToGallery

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    9fdde07 View commit details
    Browse the repository at this point in the history

  25. Add some extra effects for getting the imageData as the getMedia call… 

    … is async so need to keep circling through the innerblocks updates until we have all the data we need
    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    e657247 View commit details
    Browse the repository at this point in the history

  26. Simplify the imageData by using a useSelect

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    537f7da View commit details
    Browse the repository at this point in the history

  27. Another optimisation - only return a new imageData reference if all i… 

    …mages have data resolved
    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    c7de875 View commit details
    Browse the repository at this point in the history

  28. Refactored Gallery: Add loading state to gallery image size options (#… 

    …27087)

* Add loading spinner for image size options
Co-authored-by: Glen Davies <[email protected]>
    @aaronrobertshaw
    aaronrobertshaw authored and Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    b8fb9e5 View commit details
    Browse the repository at this point in the history

  29. Initial deprecations commit

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    09b7f2b View commit details
    Browse the repository at this point in the history

  30. Fix issue with linkDestination not being applied in migration

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    3ee43f1 View commit details
    Browse the repository at this point in the history

  31. Refactor gallery deprecations

    @aaronrobertshaw
    aaronrobertshaw authored and Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    1ae1ba2 View commit details
    Browse the repository at this point in the history

  32. Fix missing attributes from migration

    @aaronrobertshaw
    aaronrobertshaw authored and Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    15909d5 View commit details
    Browse the repository at this point in the history

  33. Update deprecation to set allowResize 

    The imageEdit component defaults the context value for allowResize to true. The refactored gallery sets this to false by default. Setting allowResize to false when migrating a deprecated gallery allows images to be cropped in the display the same as the gallery when the post is saved and gallery reloaded.
    @aaronrobertshaw
    aaronrobertshaw authored and Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    b4fbe2e View commit details
    Browse the repository at this point in the history

  34. Fix issue with crop not working when certain plugins are loaded

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    817a964 View commit details
    Browse the repository at this point in the history

  35. Fix SCSS lint errors

    @aaronrobertshaw
    aaronrobertshaw authored and Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    8eed7f4 View commit details
    Browse the repository at this point in the history

  36. Update the block example

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    b07fe67 View commit details
    Browse the repository at this point in the history

  37. Linting fixes

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    0a325dc View commit details
    Browse the repository at this point in the history

  38. Fix the e2e test and the accessibility issue with having aria group r… 

    …ole on a list item
    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    2c18948 View commit details
    Browse the repository at this point in the history

  39. fix linting issues

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    37662ca View commit details
    Browse the repository at this point in the history

  40. Fix frontend omission of wp-block-image class 

    Also tweaks the gallery styles to remove the margins the use of `wp-block-image` introduces when it is moved to the inner `figure` element.
    @aaronrobertshaw
    aaronrobertshaw authored and Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    aef6f98 View commit details
    Browse the repository at this point in the history

  41. change deprecation to use imageCount as isEligible check as it seems … 

    …that some previous block versions may not have an ids attribute
    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    24a9455 View commit details
    Browse the repository at this point in the history

  42. Move back to a single deprecations file and reorder in array

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    e59ea15 View commit details
    Browse the repository at this point in the history

  43. Remove additional check in v5 isEligible

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    fa8a159 View commit details
    Browse the repository at this point in the history

  44. Fix the v4 migration

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    97849a9 View commit details
    Browse the repository at this point in the history

  45. Fix styles for Safari compatibility

    @aaronrobertshaw
    aaronrobertshaw authored and Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    5048707 View commit details
    Browse the repository at this point in the history

  46. Remove unnecessary gallery editor styles

    @aaronrobertshaw
    aaronrobertshaw authored and Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    6abf4fe View commit details
    Browse the repository at this point in the history

  47. Fix typo in deprecations

    @aaronrobertshaw
    aaronrobertshaw authored and Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    ee6628a View commit details
    Browse the repository at this point in the history

  48. Restore styles to render deprecated gallery versions

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    0035221 View commit details
    Browse the repository at this point in the history

  49. Avoid applying flex styles to IE11

    @aaronrobertshaw
    aaronrobertshaw authored and Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    41c5a27 View commit details
    Browse the repository at this point in the history

  50. Add additional selector to prevent the hidden individual image drop z… 

    …ones ending up display flex instead of hidden
    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    5cf7a08 View commit details
    Browse the repository at this point in the history

  51. IE11 styling improvements

    @aaronrobertshaw
    aaronrobertshaw authored and Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    c748ce7 View commit details
    Browse the repository at this point in the history

  52. Apply default style class to new images added to gallery

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    cb153a1 View commit details
    Browse the repository at this point in the history

  53. fix linting issues

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    a38efbd View commit details
    Browse the repository at this point in the history

  54. Move block props to the outer wrapper

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    06dd3d5 View commit details
    Browse the repository at this point in the history

  55. Revert "Move block props to the outer wrapper" 

    This reverts commit e0723a7.
    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    77d887c View commit details
    Browse the repository at this point in the history

  56. Revert "Revert "Move block props to the outer wrapper"" 

    This reverts commit a7504fd.
    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    c2d229c View commit details
    Browse the repository at this point in the history

  57. Fetch media if isListItem is true

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    083fc42 View commit details
    Browse the repository at this point in the history

  58. Change context from isListItem to isGrouped

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    a392c2a View commit details
    Browse the repository at this point in the history

  59. Remove wrapper div

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    8b06149 View commit details
    Browse the repository at this point in the history

  60. remove extra wrapper around media placeholder and caption and use fle… 

    …x css instead
    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    260764d View commit details
    Browse the repository at this point in the history

  61. Revert "remove extra wrapper around media placeholder and caption and… 

    … use flex css instead
    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    7cbea7a View commit details
    Browse the repository at this point in the history

  62. Revert "Remove external div wrapper by moving InnerBlocks to a fragment"

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    55ff08b View commit details
    Browse the repository at this point in the history

  63. another update to image wrapper

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    d312f73 View commit details
    Browse the repository at this point in the history

  64. put media uploader outside figure so structure matches front end

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    c465a0d View commit details
    Browse the repository at this point in the history

  65. Replace div with View for the sake of native code

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    31dcd59 View commit details
    Browse the repository at this point in the history

  66. Move setting of attributes to the child images

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    fa5f89b View commit details
    Browse the repository at this point in the history

  67. Gallery Block Refactor: Account for null image ids in gallery migrati… 

    …ons (#27855)

Co-authored-by: Glen Davies <[email protected]>
    @glendaviesnz
    glendaviesnz and Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    94b9ca2 View commit details
    Browse the repository at this point in the history

  68. Remove the gradient and put caption under image if is-rounded style a… 

    …pplied (#27869)

* Add alignment fixes for non cropped images

Co-authored-by: Glen Davies <[email protected]>
    @glendaviesnz
    glendaviesnz and Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    7112959 View commit details
    Browse the repository at this point in the history

  69. Remove outer div wrapper

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    11ce2f2 View commit details
    Browse the repository at this point in the history

  70. Keep image margins while dragging sibling

    @aaronrobertshaw
    aaronrobertshaw authored and Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    a539edd View commit details
    Browse the repository at this point in the history

  71. Fix e2e test expected markup to match new structure

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    34aa703 View commit details
    Browse the repository at this point in the history

  72. Gallery Block Refactor: Add handling of short code transforms (#28211) 

    Co-authored-by: Glen Davies <[email protected]>
    @glendaviesnz
    glendaviesnz and Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    a731edc View commit details
    Browse the repository at this point in the history

  73. Removed unused prop

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    dbb1581 View commit details
    Browse the repository at this point in the history

  74. Account for undefined block and innerblocks in conversion to reusable… 

    … block lifecycle (#28336)

* At certain points in conversion to reusable the parent and innerblock are undefined so adding checks to account for this

Co-authored-by: Glen Davies <[email protected]>
    @glendaviesnz
    glendaviesnz and Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    33bda1e View commit details
    Browse the repository at this point in the history

  75. Add custom gutter sizes to refactored gallery (#28377)

    @aaronrobertshaw
    aaronrobertshaw authored and Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    c6d2d0b View commit details
    Browse the repository at this point in the history

  76. Adjust editor styles to match new dom structure

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    bea50ba View commit details
    Browse the repository at this point in the history

  77. Remove redundant styles that are duplicated in nested image blocks

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    85428a7 View commit details
    Browse the repository at this point in the history

  78. Fix issue with Image block dragged out of Gallery still having inheri… 

    …tedAttributes set
    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    a8c3dc6 View commit details
    Browse the repository at this point in the history

  79. When dragging an image block into a gallery make sure we don't wipe a… 

    …ny custom links
    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    fab3d0e View commit details
    Browse the repository at this point in the history

  80. fix issue with variable declaration order

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    5b466d6 View commit details
    Browse the repository at this point in the history

  81. Fix bug with custom link being overwritten by gallery linkTo changes

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    31ce82f View commit details
    Browse the repository at this point in the history

  82. Fix application of gutter size CSS var (#28759)

    @aaronrobertshaw
    aaronrobertshaw authored and Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    9c03251 View commit details
    Browse the repository at this point in the history

  83. Fix mobile width for gallery images

    @aaronrobertshaw
    aaronrobertshaw authored and Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    d144d72 View commit details
    Browse the repository at this point in the history

  84. Add missing dependency to inner images selector

    @aaronrobertshaw
    aaronrobertshaw authored and Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    a0b9e7d View commit details
    Browse the repository at this point in the history

  85. Fix all unit tests and block fixtures to match the refactored gallery… 

    … format
    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    58cf248 View commit details
    Browse the repository at this point in the history

  86. Fix broken e2e test

    Glen Davies committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    6af96d3 View commit details
    Browse the repository at this point in the history