Sidebar: Fix sidebar scroll overflow (Edge, Safari) #2868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
the
General Interface
Codecov Report
@@ Coverage Diff @@
## master #2868 +/- ##
==========================================
+ Coverage 33.9% 34.96% +1.06%
==========================================
Files 191 191
Lines 5699 5803 +104
Branches 999 1034 +35
==========================================
+ Hits 1932 2029 +97
- Misses 3187 3191 +4
- Partials 580 583 +3
Continue to review full report at Codecov.
|
youknowriad
approved these changes
Oct 3, 2017
There have been many many overflow issues, hence my plea for contributors to keep macOS scrollbars always visible 😛 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1899
This pull request seeks to resolve a scroll overflow which occurs in some browsers in the sidebar due to panel styling. The panel uses negative margins to prevent doubling up on borders between panels. This works well for
margin-topbut in the case ofmargin-bottom: -1px, it can result in container overflow (scroll). The changes here refactor to eliminate the double border by assigning aborder-bottom-widthon the last child of the panel, in place of the negative margin.Testing instructions:
Verify that a border is still shown at the bottom of the sidebar Discussion panel (collapsed and expanded), that the border is not doubled up, and that no scroll overflow exists in your preferred browser, Safari, or Edge (Windows).
In macOS, scrollbars are not visible by default unless scrolling. You can change this setting to always show scrollbars in System Preferences > General (and I might recommend keeping the setting this way if you work with CSS frequently).