Refactored Gallery: Add custom gutter size feature #29216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocks at the point that the block validation is run
… innerBlocks at the point that the block validation is run" This reverts commit 4d95e95.
… available at point of block validation
… gallery - with the idea that we will improve the innerblocks drag and drop in a later PR
This reverts commit 9b0abcc.
…existing gallery - with the idea that we will improve the innerblocks drag and drop in a later PR" This reverts commit cc05d60.
…transform when dragging multiple images onto the gallery
…mponent some times
… is async so need to keep circling through the innerblocks updates until we have all the data we need
…mages have data resolved
…27087) * Add loading spinner for image size options Co-authored-by: Glen Davies <[email protected]>
…attributes handled by gallery
Reasoning for removal can be found at #25940 (comment)
These changes re-apply the custom gutter size feature that was removed from the refactored gallery block PR so it could be discussed independently.
aaronrobertshaw
added
[Type] Enhancement
|
Size Change: +133 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
glendaviesnz
force-pushed
the
refactor/gallery-to-nested-image-blocks
branch
from
a5305b0
to
ff1c4af
Compare
aaronrobertshaw
requested review from
ajitbohra,
ajlende,
ellatrix,
nerrad,
ntwb,
spacedmonkey and
TimothyBJacobs
as code owners
glendaviesnz
force-pushed
the
refactor/gallery-to-nested-image-blocks
branch
4 times, most recently
from
c4dd32b
to
c72e442
Compare
glendaviesnz
force-pushed
the
refactor/gallery-to-nested-image-blocks
branch
3 times, most recently
from
f4d0ea6
to
9415d57
Compare
glendaviesnz
force-pushed
the
refactor/gallery-to-nested-image-blocks
branch
from
66bdda6
to
4e57fb3
Compare
glendaviesnz
force-pushed
the
refactor/gallery-to-nested-image-blocks
branch
from
3870131
to
d71011b
Compare
Base automatically changed from
refactor/gallery-to-nested-image-blocks
to
trunk
August 19, 2021 23:39
|
This was merged into the gallery refactor, then later removed. Now the refactored gallery has landed, it's time to close this. Also, new gap block support is about ready to land which will solve the gallery gutter spacing nicely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows for the user to specify a custom gutter size for the new refactored gallery block.
Background
The approach for this feature was originally implemented as part of the gallery refactoring. It has been split out so it can be discussed independently. A few blocks would benefit from being able to implement custom gutter sizes so a unified approach would be best, whether this is via the block supports mechanism or something more specific.
A non-gallery example of the need for custom gutter sizes can be found in the Columns block. There is already an outstanding PR adding custom gutter sizing for it, using a similar ad hoc approach to this PR.
The discussion related to this feature on the refactored gallery PR can be found here: #25940 (comment)
Possible Options
How has this been tested?
Manually.
Testing Instructions
Screenshots
Types of changes
New feature
Checklist: