Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-select: try no buffer and lower throttle delay #2935

Merged
merged 2 commits into from
Oct 27, 2017

Conversation

ellatrix
Copy link
Member

@ellatrix ellatrix commented Oct 9, 2017

Description

Let's see if this makes multi-select smoother.

@codecov
Copy link

codecov bot commented Oct 9, 2017

Codecov Report

Merging #2935 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2935      +/-   ##
==========================================
+ Coverage   31.49%   31.51%   +0.01%     
==========================================
  Files         221      221              
  Lines        6309     6305       -4     
  Branches     1122     1120       -2     
==========================================
  Hits         1987     1987              
+ Misses       3632     3630       -2     
+ Partials      690      688       -2
Impacted Files Coverage Δ
editor/modes/visual-editor/block-list.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12d459a...da80229. Read the comment docs.

@jasmussen
Copy link
Contributor

I can't believe I missed this, sorry about that.

Given other changes we have in the pipeline, including the keyboard stuff, it seems like the pattern to emulate here is that of the real text editor, despite being a multi instance block editor. As such, my initial assessment that we'd want to be careful to invoke multi selection seems squarely wrong on the face of it! Live and learn, right?

Thanks so very much for working on this, and I think we should try and get this in master! 👍 👍

@mcsf mcsf force-pushed the try/no-multi-select-buffer branch from d6e497f to da80229 Compare October 27, 2017 11:12
Copy link
Contributor

@mcsf mcsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've rebased and pushed a little refactor. If you're OK with it, :shipit:

@ellatrix
Copy link
Member Author

Looks great, let's merge.

@ellatrix ellatrix merged commit f7b8a1c into master Oct 27, 2017
@ellatrix ellatrix deleted the try/no-multi-select-buffer branch October 27, 2017 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants