Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep post publishing popover open when a date is clicked, by default #29893

Merged

Conversation

allilevine
Copy link
Contributor

Description

Follow-up to #29738 to remove the keepOpen prop and keep focus on the date picker by default.

How has this been tested?

  1. Create a new post
  2. Open the schedule popover by clicking on the publish date
  3. Click on a date in the picker and confirm that the popover does not close.
  4. Navigate to the next month
  5. Click on a date and confirm that the popover does not close.
  6. Navigate to a date via the keyboard and select it. Confirm that the popover does not close.

Screenshots

Gif of the popover staying open after clicking on a date:
datetimepickerstaysopen

Types of changes

Bug fix: Uses keepFocusInside() to keep the date picker open on date change.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

Copy link
Contributor

@retrofox retrofox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks, Allison. Tested in the editor as well as in the storybook. 👍

Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow-up :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants