Rename experimental-theme.json to theme.json and add a fallback for backwards-compatibility #29981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aristath
added
[Feature] Themes
aristath
requested review from
youknowriad,
oandregal,
gziolo,
kjellr and
ntsekouras
aristath
requested review from
ajitbohra,
chrisvanpatten and
spacedmonkey
as code owners
|
cc @JustinyAhin for a review of the docs changes |
|
Thanks for the PR Ari, It's great to have this ready. I think we should hold a bit on this PR until we make the necessary changes suggested in #29891 |
Sure, though with the fallback in https://github.com/WordPress/gutenberg/pull/29981/files#diff-41112e4d1e1b9d7fe224c7c598fb56d7ed165d57335008129e1c4658252fb037 I don't think anything will break 😉 |
|
Size Change: 0 B Total Size: 1.31 MB ℹ️ View Unchanged
|
|
It's more about the "format" for me and also a "communication" aspect. If we decide that we need some small breaking change in the format. For an experimental file, it's clearly mentioned on our docs that changes are expected https://developer.wordpress.org/block-editor/contributors/code/coding-guidelines/#experimental-and-unstable-apis |
|
Makes sense 👍 |
|
Time to get this one refreshed and merge. The new format is in. Thanks for the patience :) |
aristath
force-pushed
the
rename/experimental-theme
branch
from
f74a815
to
80ed51e
Compare
youknowriad
approved these changes
May 5, 2021
carolinan
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the FSE MVP closing in, we should rename
experimental-theme.jsontotheme.json.This PR makes the necessary changes to documentation files, and also in the JSON resolver.
For backwards-compatibility and to avoid existing FSE themes from breaking, this PR also adds a fallback so if
theme.jsoncan't be found it tries to useexperimental-theme.json.How has this been tested?
Tested with an existing FSE theme and nothing seems to be breaking. Then renamed the
experimental-theme.jsonfile totheme.jsoninside the theme root folder, and again nothing breaks.Checklist: