Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gallery block refactor: make invalid file type errors consistent #30396

Merged
merged 3 commits into from
Mar 31, 2021
Merged

Gallery block refactor: make invalid file type errors consistent #30396

merged 3 commits into from
Mar 31, 2021

Commits on Mar 30, 2021

  1. Make warnings about invalid file types more consistent

    Glen Davies committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    8661bf0 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2021

  1. Use ALLOWED_MEDIA_TYPES constant to check valid types

    Glen Davies committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    89be84c View commit details
    Browse the repository at this point in the history

  2. Prevent some of the duplicate notices 

    These changes prevent duplicate notices within both the gallery component itself and the general notices at the top of the editor. Given the gallery component's notices are via the withNotices HoC, we can't access that notice list to remove the notice via the notice store's `removeNotice`.
    @aaronrobertshaw
    aaronrobertshaw committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    96c8fd1 View commit details
    Browse the repository at this point in the history