Try: Provide a baseline submenu background color. #30831
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Block] Navigation
jasmussen
requested review from
scruffian,
oandregal,
gziolo,
kjellr and
MaggieCabrera
|
Size Change: +64 B (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
oandregal
reviewed
Apr 16, 2021
| // This includes blocks that have a background color, | ||
| // as you might switch themes and the color specified is no longer registered. | ||
| // But when one is explicitly chosen after the fact, it will override these rules. | ||
| .wp-block-navigation.has-background, |
There was a problem hiding this comment.
Right. Weird situation. The fact that we attach presets as classes make switching themes fragile. I hope this can be lessened by having "core" colors #29568 but still there will be situations in which there may be preset theme colors.
I wonder if 29568 is a good opportunity to revisit how we do colors and whether presets can be inline colors (so we fix the theme switching issue).
7 tasks
|
I'm going to close this one. I think there's still a conversation to be had, but I'm not comfortable adding too many edgecase handlings directly to this block. The concern I think is worth thinking about, but handling for all blocks, not just this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This one is a bit unique, and is a followup inspired by work in #30805. It is a draft because it is in part more of a question about best practices, and the fix attached I only have medium confidence level in.
Situation: the navigation block allows submenus. When a submenu has a color set by the user, we can then colorize submenus according to that color (see also #29963).
When the navigation block does not have an explicitly set background color, we have to choose a background color for submenus, they can't just be transparent. But as soon as we choose a background color, we have to also choose a text color. Right now we do this by assigning a white background and black text with a
:not(.has-background) { background-color: inherit; color: inherit; }rule. It works well enough.However a theme can assign a palette. For example I have a
bright-red. So when I assign that to my navigation block, it gets classeshas-background has-bright-red-background-color. The tricky bit is, those classes continue to exist when I switch from one theme to another, and that other theme likely doesn't have abright-redcolor defined. In that case, my navigation block will now have transparent submenus, because the CSS assumes there is a background color, even when one isn't actually defined:This PR fixes that by assigning the white background even when the block has a background, but then relies on the color definition when present to override it. Here's what that looks like when the color is not defined:
But what's the best practice here? Presumably the problem is the same if I set a background color on my paragraph, then switch themes?
Checklist:
*.native.jsfiles for terms that need renaming or removal).