Add a welcome guide to the template editor. #31330
Conversation
|
Size Change: +178 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
|
For 5.8 it's important to have that (or an alternative version of it) in the "template mode" of the post editor. The site editor is not being shipped in 5.8, so it's a bit less important. |
|
@youknowriad so conditionally render different "Welcome Guide" when post type is |
|
no, more something like this:
|
|
Thank you for the clarification; it makes sense. I will update the code and logic. |
|
Updated logic to conditionally render Welcome Guide and removed old one from |
|
Nice 🚀 I think we'll definitely need to update the copy for 5.8 though. The third slide can be removed altogether for now, since global styles wont be present. The first two can perhaps be combined?
|
Sounds good. Do you want me to push this update, or should we wait for design feedback from others? |
|
Probably ok to push now and refine while we work on the graphics. |
|
How is this looking? Should we remove the snackbar with this addition ? cc @mtias Also, I think this welcome guide is an opportunity to expand on this mode more, this one is different than the site editor, I think it should say things like:
WDYT? cc @jameskoster |
|
The copy has been updated to remove the Site Editor parts:
I think this is inherently implied by the flow: Edit page -> Edit template.
A slide to cover this makes sense, but we need to strike the right balance between informing and intimidating. Maybe something like:
|
|
This looks like it heading in a nice direction! |
|
As a full time WP dev, I would like to see a way of turning it off as it gets annoying after seeing over 100 times. |
|
@cgaits you should only see it once 👍 |
It was not a clear comment, I apologize. As a dev, I build multiple pages and websites in a workweek; I see it pop up many times. My comment should have been is there a way to turn it on or off in the settings, and is it worth to add other such features in settings, for example what type of the widget screen we see, classic or new... Setting is usually the first part of WordPress customization. |
|
Turning it off in the settings honestly sounds like more work than simply clicking the |
|
Any thoughts @youknowriad? I'm thinking this would be ok to merge, and we can refine the slides (if needed) once have a clearer picture of exactly what template editing functionality will ship in 5.8. |
youknowriad
force-pushed
the
try/site-editor-welcome-guide
branch
from
e4f7343
to
0e0142b
Compare
|
Sounds good to me, what about removing the snackbar notice? Isn't it just a duplication now? |
|
Yes I think that's fair. The welcome guide + the frame should be adequate in communicating when a user is in template editing mode. |
Mamaduka
changed the title
|
While trying to remove the notices, I kind of changed my mind :P. The snackbars can be useful if it's not the first time you go into template mode (say you create a template for a post but you already got the introduction). Let's keep them for now and reconsider later. |
|
I also find them useful reminders. |
youknowriad
force-pushed
the
try/site-editor-welcome-guide
branch
from
0e0142b
to
c7f948d
Compare
youknowriad
changed the title
|
Looks like the change here introduced a failure in e2e tests, I think the welcome guide is getting in the way of the test :) Maybe we can do something like the post editor and auto close this automatically. Is this something you can help with @Mamaduka ? |
|
@youknowriad I can try to have a look later today but might be too late for a release. P.S. Sorry, I would love to do it now, but currently in line for my vaccine jab 💉 |
|
I can take a look. |
|
Testing. WordPress 5.7.2. Twenty Twenty One. This is what I see: Welcome-Guide-Page-Post-Template.mp4It is really helpful having the Welcome Guide in place. |
talldan
force-pushed
the
try/site-editor-welcome-guide
branch
from
fbb99c8
to
c354833
Compare
|
c354833 should fix the tests, and I've rebased so that the fixes in |
|
Thanks @talldan |
|
Thanks, @talldan. |
Co-authored-by: Daniel Richards <[email protected]>
Description
See #29031.
WIP PR for the Welcome Guide for Site/Template editor. It should be visible by default when the post editor is in "template mode."
To toggle the feature use following code snippett in console or use "Options" menu:
Todos
Screenshots
CleanShot.2021-04-29.at.16.44.36.mp4
Checklist:
*.native.jsfiles for terms that need renaming or removal).