-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moves hermes and react-native mirror to S3 #31441
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 1.31 MB ℹ️ View Unchanged
|
oguzkocer
added
the
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
label
May 3, 2021
cameronvoell
approved these changes
May 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good! Tested demo app on android and the refresh dependencies command and both looked good. 👍
2 tasks
cameronvoell
pushed a commit
that referenced
this pull request
May 7, 2021
dcalhoun
added a commit
that referenced
this pull request
May 7, 2021
* Release script: Update react-native-editor version to 1.52.0 * Release script: Update with changes from 'npm run core preios' * Updating react-native-editor change log * Release script: Update react-native-editor version to 1.52.1 * Release script: Update with changes from 'npm run core preios' * Moves hermes and react-native mirror to S3 (#31441) * Update release notes Co-authored-by: Cameron Voell <[email protected]> Co-authored-by: Oguz Kocer <[email protected]> Co-authored-by: David Calhoun <[email protected]>
jd-alexander
added a commit
that referenced
this pull request
May 14, 2021
* Release script: Update react-native-editor version to 1.52.0 * Release script: Update with changes from 'npm run core preios' * Updating react-native-editor change log * Release script: Update react-native-editor version to 1.52.1 * Release script: Update with changes from 'npm run core preios' * Moves hermes and react-native mirror to S3 (#31441) * Update release notes * Release script: Update react-native-editor version to 1.52.2 * Release script: Update with changes from 'npm run core preios' * [RNMobile] Disable featured image banner on iOS (#31681) * disabled featured image banner on iOS. * Added CHANGELOG entry. * check if the featured image id is undefined before performing operation * updated CHANGELOG with beta fix. Co-authored-by: Cameron Voell <[email protected]> Co-authored-by: Carlos Garcia <[email protected]> Co-authored-by: Oguz Kocer <[email protected]> Co-authored-by: David Calhoun <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates
react-native-bridge
,react-native-aztec
andreact-native-editor
projects to use react native mirror and hermes binaries from S3 repo instead of Bintray. This change is made due to Bintray shutting down.How has this been tested?
react-native-aztec/android
run./gradlew build --refresh-dependencies
react-native-editor/android
run./gradlew :app:buildDebug --refresh-dependencies
react-native-bridge/android
run./gradlew :react-native-bridge:build --refresh-dependencies
react-native-bridge/android
run./gradlew :react-native-aztec:build --refresh-dependencies -PreactNativeAztecVersion=v1.52.0
react-native-bridge/android
run./gradlew :react-native-bridge:build --refresh-dependencies -PpublishReactNativeBridgeVersion=v1.52.0 -PreactNativeAztecVersion=v1.52.0
Types of changes
Maven repository changes for
react-native-bridge
,react-native-aztec
andreact-native-editor
projectsChecklist:
*.native.js
files for terms that need renaming or removal).