Fix duotone padding crash #31780
Merged
Fix duotone padding crash #31780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajlende
added
[Type] Bug
|
Size Change: -5 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
May 13, 2021
|
@ajlende I updated my comment. It all works now. I missed a step when setting up my PR testing suite. |
|
The PR works well for me. |
carolinan
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #31766
Some of the other block supports filter out falsy values from the entirety of the
styleobject. However, lodash'spickByfunction will convert an Array into an Object, causing thecolor.forEachto beundefinedwhen duotone is processing the colors.This change makes sure that Arrays are not affected by the filtering which fixes the issue.
How has this been tested?
Screenshots
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).