Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Prevent "Undo Level" after Setting Featured Image via Image Block #33057

Merged
merged 19 commits into from
Aug 9, 2021

Commits on Jun 28, 2021

  1. Ignore edits to featured image in undo history

    "editEntityRecord" includes an "undoIgnore: true" parameter that makes it possible to ignore an edit in the undo history. Reference: https://developer.wordpress.org/block-editor/reference-guides/data/data-core/#editEntityRecord
    
    With this commit, that parameter is set to true so that a new undo level *isn't* created after the featured image is updated via the app.
    Siobhan committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    c5b3a9d View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2021

  1. Configuration menu
    Copy the full SHA
    34a092c View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2021

  1. Configuration menu
    Copy the full SHA
    a75aa91 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2021

  1. Configuration menu
    Copy the full SHA
    8c7f6d9 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2021

  1. Add "featured image" section heading

    By adding the settings for changing a featured image under their own section heading, it's being clearly separated from the other sections.
    
    This will help with the overall alignment/rhythm of the settings panel, which is important given we're adding an additional note.
    Siobhan committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    3611fa9 View commit details
    Browse the repository at this point in the history
  2. Add FooterMessageControl to settings

    We're adding a note to the image block's setting to let users know that they won't be able to revert changes via the undo/redo button.
    Siobhan committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    958cbad View commit details
    Browse the repository at this point in the history
  3. Tweak featured button styles

    With this commit, we're aligning the featured button to the left and changing its border to display at the bottom. This follows design feedback here: #33057 (comment)
    Siobhan committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    f574039 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2021

  1. Tweaks to footer text

    This commit updates the footer text following feedback from editorial.
    Siobhan committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    27f2623 View commit details
    Browse the repository at this point in the history
  2. Remove bottom border from button

    Siobhan committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    89f15ac View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    47fb632 View commit details
    Browse the repository at this point in the history
  4. Remove bottom padding from button

    Siobhan committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    6ac5e79 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2021

  1. Align button and footer text to top

    With this commit, the content in the "Set as Featured" button and the footer message is aligned to the top of their containers.
    
    This will prevent flexbox from automatically adding spacing to the top of their containers, which goes against the design we want.
    Siobhan committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    604db68 View commit details
    Browse the repository at this point in the history
  2. Add title style to "Featured Image" panel

    As we need to tweak the spacing around the panel's title, I've added a new "titleStyle" prop to the PanelBody component.
    
    That prop is then used to remove the bottom spacing for the "Featured Image" panel's title.
    
    The prop can now be re-used by anyone else who needs to tweak the title in a PanelBody in the future.
    Siobhan committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    795f309 View commit details
    Browse the repository at this point in the history
  3. Add top/bottom padding to button

    Following the previous changes, this commit increases the height and "tappable area" of the "Set/Remove as Featured Image" button by adding both top and bottom padding.
    Siobhan committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    fa0d455 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a14cbe6 View commit details
    Browse the repository at this point in the history
  5. Update function name

    Due to an error when merging, the code was referencing an old function name, "getSetFeaturedButton". It should instead reference the name name, "getFeaturedButtonPanel".
    Siobhan committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    658d005 View commit details
    Browse the repository at this point in the history
  6. Update selector name

    For consistency with other selectors, this commit updates the name of "setFeaturedCellContainer" to "setFeaturedButtonCellContainer".
    Siobhan committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    2856d5a View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2021

  1. Configuration menu
    Copy the full SHA
    823df2b View commit details
    Browse the repository at this point in the history
  2. Group FooterMessageControl into "Featured" panel

    The placement of the component is moved within the main "Featured Image" panel, as this is more semantically correct than having the component within its own, separate panel.
    Siobhan committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    5662508 View commit details
    Browse the repository at this point in the history