[WIP] Refactor/gallery to nested image blocks bug fix #34133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
requested review from
ajitbohra,
ellatrix,
mkevins,
spacedmonkey and
TimothyBJacobs
as code owners
glendaviesnz
added
the
[Block] Gallery
glendaviesnz
changed the base branch from
trunk
to
refactor/gallery-to-nested-image-blocks
glendaviesnz
changed the title
glendaviesnz
added
the
[Status] In Progress
|
Size Change: +6.79 kB (+1%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
|
@talldan, @ellatrix, @youknowriad do you have any thoughts on the best way to fix this issue? |
|
Yeah, I concur, Seems related to the zombie state issues - #32088 was a recent fix for related problems. |
|
Judging by #32088, the errors are now being logged rather than thrown (before that change this might have caused the editor to crash), and they won't cause any user facing issues. I'm not sure what the right fix would be to prevent the errors, maybe the guards are fine? |
|
@ellatrix given that this issue doesn't cause an editor crash like the useSelect zombie block issue, do you think we should just leave these console errors, or is adding the guards in this PR a good idea? |
talldan
approved these changes
Aug 19, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #34098, but this is PR is really just to highlight where the exceptions are being thrown, rather than as a final solution to the problem.
It seems that the issue is that under certain circumstances there is a race condition that causes the
useBlockPropsof an Image block to still run after the Image block it is attached to has been deleted by a call toreplaceInnerBlocks.A better solution would be to prevent the offending calls being made once a block has been deleted, but I haven't found a way to do that yet, so open to ideas on that.
To test
Screenshots
See #34098
Types of changes
Adds optional chaining operators to prevent exceptions if useBlockProps runs after related block deleted.