Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post terms: add font weight support to the block #34142

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Post terms: add font weight support to the block #34142

merged 1 commit into from
Aug 19, 2021

Conversation

MaggieCabrera
Copy link
Contributor

Description

This PR adds font-weight support to the post terms block.
Insert a Post Terms block, try to change the font-weight of it

Screenshots

Screenshot 2021-08-18 at 16 57 48

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@MaggieCabrera MaggieCabrera added the [Block] Post Terms Affects the Post Terms Block label Aug 18, 2021
@MaggieCabrera MaggieCabrera self-assigned this Aug 18, 2021
@MaggieCabrera MaggieCabrera mentioned this pull request Aug 18, 2021
Merged
ntsekouras
ntsekouras approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Maggie! 👍

@ntsekouras ntsekouras merged commit f784ec9 into trunk Aug 19, 2021
@ntsekouras ntsekouras deleted the add/post-terms-fontweight-support branch August 19, 2021 09:00
@github-actions github-actions bot added this to the Gutenberg 11.4 milestone Aug 19, 2021
@t-hamano t-hamano mentioned this pull request Jul 29, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntsekouras ntsekouras ntsekouras approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@scruffian scruffian Awaiting requested review from scruffian

@jffng jffng Awaiting requested review from jffng

@mtias mtias Awaiting requested review from mtias

Assignees

@MaggieCabrera MaggieCabrera

Labels
[Block] Post Terms Affects the Post Terms Block
Projects
None yet
Milestone
Gutenberg 11.4
Development

Successfully merging this pull request may close these issues.
2 participants
@MaggieCabrera @ntsekouras