-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish submenu indicator button. #35030
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Size Change: -61 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
carolinan
approved these changes
Sep 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in multiple browsers, variations, and themes without issues.
My only concern is the click target size on mobile because the arrow is very close to the text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There's a small discrepancy between frontend and editor for the dropdown indicator, where on the frontend, the separate button has a lot of padding. Here's the editor, showing no padding around the indicator:
Here's the frontend, showing extra padding around the chevron:
This PR makes the padding the same, zero, and reduces the specificity so themes can more easily style this. Editor:
Frontend:
Note that in the editor, the submenu indicator is shown inside the
a
, whereas on the frontend it's outside, so items with underlines like shown above are cropped. That's something to consider separately.How has this been tested?
Insert a navigation block with submenus, ensure the "Show submenu indicator icons" property is toggled, and compare editor with frontend.
Checklist:
*.native.js
files for terms that need renaming or removal).