Remove font size classes that are enqueued in the global stylesheet #35182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
[Type] Performance
|
Size Change: -213 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
oandregal
commented
Sep 28, 2021
| @@ -8,26 +8,12 @@ | |||
| @include gradient-colors-deprecated(); | |||
| } | |||
|
|
|||
| // Font sizes. | |||
| .has-small-font-size { | |||
| font-size: 0.8125em; | |||
There was a problem hiding this comment.
@jasmussen I've noticed that in the common.scss bundled the classes used em while in the editor.scss bundled they used px. Looked at the history but this seems to be like that since the beggining. Do you happen to remember why that difference by any chance? Is it safe to substitute them with the theme.json values in px?
There was a problem hiding this comment.
Good catch. There's a lot of discussion around ems vs. px, but since we have a unit selector in the interface, px provides a default that's fairly easy to understand in comparison.
So why are the values in px in the editor and em in the interface? Good question, that seems like an oversight.
Is it safe to remove? Almost certainly. Looking at the values, we have 0.8125em for "small", which maps to 13px in theme.json. The math checks out because ems are based on the parent font size, which in the case of the body element is 16px by default. And 0.8125 * 16 = 13.
Two issues:
- The problem is that ems are not rems, and they take their value from the parent. Meaning there could be nested cases where the font size wouldn't match.
- The other issue is if the theme sets the font size on the body element to something other than 16px, then the math will be wrong.
But in both cases, it appears those issues are in trunk and already shipping, meaning all this PR does is correct an error. It also appears that the global styles that are output have already corrected this error, meaning this is just code cleanup.
There was a problem hiding this comment.
Right, since we load the global stylesheet for all themes, the core classes enqueued there are overriding these styles already.
jasmussen
approved these changes
Oct 13, 2021
This was referenced Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34006
Follows up to what we did for colors #34138
This removes the CSS classes bundled in the
block-librarypackage that we're already enqueuing in the global stylesheet, to avoid enqueuing them twice.How to test
These classes are only used by themes that don't add a palette on their own, so they use the core presets: small, normal, medium, large, huge.
Theme with
theme.json: TT1-blockssettings.typography.fontSizessection.Also:
wp-block-library-cssstylesheet and verify that it only contains classes forregularandlarger.Theme without
theme.json: TwentyTwentyfunctions.phpfile and comment this line:add_theme_support('editor-font-sizes', ... );Also:
wp-block-library-cssstylesheet and verify that it only contains classes forregularandlarger.