Improve focus styles for Link UI preview title #35853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing unnecessary overflow allows focus to display correctly.
|
@jasmussen Please can you clarify what you meant in #35833 (comment) by
Please could you confirm what values should be used on the link when
|
getdave
added
the
[Feature] Link Editing
7 tasks
|
Size Change: -36 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Oct 22, 2021
There was a problem hiding this comment.
Nice one:
The code you changed suggests that the overflow controls were meant to clip/elide search item details. Did you verify this didn't regress as part of changing the code?
To clarify what I meant about the old focus style — here's the new focus style:
It's a solid outline with no blur, set in the same color as your admin theme.
But since the focus style for this control is inherited from wp-admin, it's fair to say the focus style should be updated there, not here.
getdave
added
the
[Focus] Accessibility (a11y)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing unnecessary overflow allows focus to display correctly.
Description
IN #35833 (comment) we learnt from @jasmussen that the focus ring on the Link UI's preview was incorrect in that:
This PR
fixes both of those problemscurrently only fixes the first of those problems whilst I wait on further feedback and clarification.How has this been tested?
www.wordpress.orgas that brings up a nice rich preview.Check text color is correct(not yet ready!).overflow: hiddens hasn't caused any visual regressions. I don't believe it's needed anymore because we wrap the text rather than ellipsis it.Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).