Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColorPicker: Enlarge input sizes #36193

Closed
wants to merge 3 commits into from
Closed

Conversation

mirka
Copy link
Member

@mirka mirka commented Nov 4, 2021

⏳ On hold until #35646 lands

Description

The input heights were already 40px, but this removes the override styles and instead passes a size="__unstable-large" prop to the underlying component.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

To prevent unnecessary truncation in mobile-width viewports when the font size gets bigger.
@mirka mirka added [Package] Components /packages/components [Feature] Component System WordPress component system labels Nov 4, 2021
@mirka mirka self-assigned this Nov 4, 2021
@mirka
Copy link
Member Author

mirka commented Jun 28, 2022

Closing in favor of #42002 and #42004

@mirka mirka closed this Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Component System WordPress component system [Package] Components /packages/components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant