Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port global styles code to lib/compat/wordpress-5.9: css custom properties #37334

Merged
merged 3 commits into from
Dec 14, 2021

Conversation

oandregal
Copy link
Member

This PR continues porting global styles code into lib/compat/wordpress-5.9 folder. See related core PR where this is being backported WordPress/wordpress-develop#2048 (comment)

How to test

  • Activate the TwentyTwentyTwo theme.
  • Load the site editor.
  • Go to the editor palette in the global styles sidebar and click the gradients tab.

The expected result is that gradients are visualized properly:

Captura de ecrã de 2021-12-13 17-52-26

@oandregal oandregal self-assigned this Dec 13, 2021
@oandregal oandregal added [Type] Code Quality Issues or PRs that relate to code quality Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Dec 13, 2021
@oandregal oandregal requested review from a team, getdave and aristath and removed request for a team December 13, 2021 17:21
@oandregal oandregal changed the title Port more global styles code to lib/compat/wordpress-5.9 Port global styles code to lib/compat/wordpress-5.9: css custom properties Dec 13, 2021
Copy link
Member

@aristath aristath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@oandregal oandregal merged commit 8d9f385 into trunk Dec 14, 2021
@oandregal oandregal deleted the update/css-props-in-5-9 branch December 14, 2021 09:44
@github-actions github-actions bot added this to the Gutenberg 12.2 milestone Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants