Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tip icon to library and use in the Tip component #38424

Merged
merged 3 commits into from
Feb 2, 2022

Conversation

ndiego
Copy link
Member

@ndiego ndiego commented Feb 1, 2022

Description

This simple PR furthers the mission of ensuring all icons used in the Gutenberg UI are actually available in the icons library and are not hardcoded. One such icon is the Tip icon (lightbulb), which is used at the bottom of the inserter (see screenshot).

In this PR, the svg code for the icon is moved to the icons library and the Tip component is updated to reflect this change. This issue was originally mentioned here #35187 (comment) and I just now got to it 😅

Testing Instructions

  1. Open the inserter and make sure the Tip icon looks the same as it did previously.

Screenshots

image

Types of changes

New feature

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
  • I've updated related schemas if appropriate.

@ndiego ndiego added the [Package] Icons /packages/icons label Feb 1, 2022
@ndiego ndiego requested a review from jasmussen February 1, 2022 19:36
@ndiego ndiego self-assigned this Feb 1, 2022
Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, matches icon name in Figma, tests well:
Screenshot 2022-02-02 at 07 35 02

Excellent cleanup, nice work!

@ndiego ndiego merged commit 23279d1 into WordPress:trunk Feb 2, 2022
@ndiego ndiego deleted the add/tip-icon-to-library-and-use branch February 2, 2022 10:58
@github-actions github-actions bot added this to the Gutenberg 12.6 milestone Feb 2, 2022
@jasmussen
Copy link
Contributor

Oh, I guess we should mention this in the changelog, my bad. @ndiego would you mind adding a small note?

https://github.com/WordPress/gutenberg/blob/trunk/packages/icons/CHANGELOG.md

@ndiego
Copy link
Member Author

ndiego commented Feb 2, 2022

@jasmussen oh good catch. I have updated here #38450

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Icons /packages/icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants