Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core Data: TypeScript definitions for entity records. #38666

Merged
merged 74 commits into from
Feb 22, 2022
Merged

Core Data: TypeScript definitions for entity records. #38666

merged 74 commits into from
Feb 22, 2022

Commits on Feb 9, 2022

  1. Add types for core data entity records

    @adamziel
    adamziel committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    8d9ab6d View commit details
    Browse the repository at this point in the history

  2. Use string enums instead of numeric ones

    @adamziel
    adamziel committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    190ccdf View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2022

  1. Put each type in a separate file

    @adamziel
    adamziel committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    6d9687b View commit details
    Browse the repository at this point in the history

  2. Rond 2 of autogenerating types

    @adamziel
    adamziel committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    de331e0 View commit details
    Browse the repository at this point in the history

  3. Extract enum types

    @adamziel
    adamziel committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    1300f77 View commit details
    Browse the repository at this point in the history

  4. Extract common interfaces

    @adamziel
    adamziel committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    60d1c91 View commit details
    Browse the repository at this point in the history

  5. Add type definitions for posts and template parts

    @adamziel
    adamziel committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    9cb67ca View commit details
    Browse the repository at this point in the history

  6. Add Raw Data typings

    @adamziel
    adamziel committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    08081f7 View commit details
    Browse the repository at this point in the history

  7. Extract AvatarUrls to common.js

    @adamziel
    adamziel committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    cd9b910 View commit details
    Browse the repository at this point in the history

  8. Try context-based entity types

    @adamziel
    adamziel committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    2449089 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2022

  1. Experimenting with different ways of contextualizing data types

    @adamziel
    adamziel committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    5f35431 View commit details
    Browse the repository at this point in the history

  2. Remove EntityInContext – it isn't really needed

    @adamziel
    adamziel committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    566c954 View commit details
    Browse the repository at this point in the history

  3. Rename RawDataIsString to RawDataOverride

    @adamziel
    adamziel committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    5969c12 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2022

  1. Use Entity and EntityWithEdits without distinguishing between differe… 

    …nt contexts
    @adamziel
    adamziel committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    4d8ea95 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2022

  1. Make all the fields contextual

    @adamziel
    adamziel committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    4ff84bb View commit details
    Browse the repository at this point in the history

  2. Refactir WithEdits to EditedRecord

    @adamziel
    adamziel committed Feb 16, 2022
    Configuration menu
    Copy the full SHA
    b73646b View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2022

  1. Rename "Edited" to "Updatable"

    @adamziel
    adamziel committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    a20c2a1 View commit details
    Browse the repository at this point in the history

  2. Flatten Nevers and WithoutNevers to OmitNevers

    @adamziel
    adamziel committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    539f7c2 View commit details
    Browse the repository at this point in the history

  3. Remove dedicated updatable fields in favor of an Updateble type wrapper

    @adamziel
    adamziel committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    1c420c0 View commit details
    Browse the repository at this point in the history

  4. Remove extra wrappers around types

    @adamziel
    adamziel committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    942f152 View commit details
    Browse the repository at this point in the history

  5. Add missing definitions to NavMenu type

    @adamziel
    adamziel committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    f13eda1 View commit details
    Browse the repository at this point in the history

  6. Use RawField in Page and Post types

    @adamziel
    adamziel committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    433be4f View commit details
    Browse the repository at this point in the history

  7. Export UpdatableRecord type

    @adamziel
    adamziel committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    62963d9 View commit details
    Browse the repository at this point in the history

  8. Rename RawField to RenderedText

    @adamziel
    adamziel committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    6554342 View commit details
    Browse the repository at this point in the history

  9. Export updatable types

    @adamziel
    adamziel committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    ec99125 View commit details
    Browse the repository at this point in the history

  10. Rename UpdatableRecord to Updatable

    @adamziel
    adamziel committed Feb 17, 2022
    Configuration menu
    Copy the full SHA
    4292622 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2022

  1. Remove atomic updatable types

    @adamziel
    adamziel committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    dde6773 View commit details
    Browse the repository at this point in the history

  2. Adjust Comment status and User locale modeling

    @adamziel
    adamziel committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    e9ee4d0 View commit details
    Browse the repository at this point in the history

  3. Remove the NestedWidget name, declare the type inline in Sidebar

    @adamziel
    adamziel committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    dcdabe5 View commit details
    Browse the repository at this point in the history

  4. Make User.password optional

    @adamziel
    adamziel committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    31e1ea9 View commit details
    Browse the repository at this point in the history

  5. Introduce StringWhenUpdatable type to model WP templates

    @adamziel
    adamziel committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    d81c259 View commit details
    Browse the repository at this point in the history

  6. Document the Updatable type

    @adamziel
    adamziel committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    e6193b2 View commit details
    Browse the repository at this point in the history

  7. Document the RenderedText using @dmsnell's proposal

    @adamziel
    adamziel committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    a95ba80 View commit details
    Browse the repository at this point in the history

  8. Document types in common.ts

    @adamziel
    adamziel committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    0e4c63e View commit details
    Browse the repository at this point in the history

  9. Flatten the content prop of WpTemplate and WpTemplatePart into a stri… 

    …ng through a condition inside the Updatable type wrapper
    @adamziel
    adamziel committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    09fe23a View commit details
    Browse the repository at this point in the history

  10. Type the remaining optional fields more strictly

    @adamziel
    adamziel committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    4974607 View commit details
    Browse the repository at this point in the history

  11. Wrap Type with OmitNevers

    @adamziel
    adamziel committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    c086bab View commit details
    Browse the repository at this point in the history

  12. Wrap the type user with OmitNevers

    @adamziel
    adamziel committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    b4b0dd7 View commit details
    Browse the repository at this point in the history

  13. Use consistent kebab case in type files

    @adamziel
    adamziel committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    f153a3a View commit details
    Browse the repository at this point in the history

  14. Wrap comment with OmitNevers

    @adamziel
    adamziel committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    ee55c45 View commit details
    Browse the repository at this point in the history

  15. Add the missing OmitNevers to types with contextual fields

    @adamziel
    adamziel committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    9ba701f View commit details
    Browse the repository at this point in the history

  16. Add README.md

    @adamziel
    adamziel committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    b5560c1 View commit details
    Browse the repository at this point in the history

  17. Rename common.ts to helpers.ts

    @adamziel
    adamziel committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    8bd4641 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2022

  1. Model WpTemplate.content and WpTemplatePart.content as RenderableText

    @adamziel
    adamziel committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    184bbe4 View commit details
    Browse the repository at this point in the history

  2. Link to the REST API docs when explaining contexts

    @adamziel
    adamziel committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    185ecfd View commit details
    Browse the repository at this point in the history

  3. Explain the ContextualFields without meandering on the implementation… 

    … details of `never` fields
    @adamziel
    adamziel committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    0486076 View commit details
    Browse the repository at this point in the history

  4. Use the correct capitalization of the word javascript

    @adamziel
    adamziel committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    493050e View commit details
    Browse the repository at this point in the history

  5. Rename CommentStatus to CommentingStatus in context of comments conta… 

    …iner
    @adamziel
    adamziel committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    222e2fa View commit details
    Browse the repository at this point in the history

  6. Use Post as an example illustrating the usage of ContextualField

    @adamziel
    adamziel committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    fccae67 View commit details
    Browse the repository at this point in the history

  7. Focus on the goal of the ContextualField in its documentation

    @adamziel
    adamziel committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    d8522e8 View commit details
    Browse the repository at this point in the history

  8. Use a cleaner explanation of the Updatable type wrapper

    @adamziel
    adamziel committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    3fe2297 View commit details
    Browse the repository at this point in the history

  9. Explain why the types do not provide full type safety

    @adamziel
    adamziel committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    c544fef View commit details
    Browse the repository at this point in the history

  10. Remove the TODO comments from the README and a section about extendab… 

    …ility
    @adamziel
    adamziel committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    1b7963e View commit details
    Browse the repository at this point in the history

  11. Add extensible type prefix

    @adamziel
    adamziel committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    b855db9 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2022

  1. a -> an

    @adamziel
    adamziel committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    5b2145d View commit details
    Browse the repository at this point in the history

  2. Use export type and import type declarations

    @adamziel
    adamziel committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    b23a08a View commit details
    Browse the repository at this point in the history

  3. Note that Comment.id is still a field even after the Comment type has… 

    … been extended
    @adamziel
    adamziel committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    c98911e View commit details
    Browse the repository at this point in the history

  4. Use CommentingStatus and PingStatus in the Attachment type

    @adamziel
    adamziel committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    c02ddb3 View commit details
    Browse the repository at this point in the history

  5. Use a correct snippet of code to illustrate interface extending in RE… 

    …ADME.md
    @adamziel
    adamziel committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    a0650ac View commit details
    Browse the repository at this point in the history

  6. Use namespaced base types for extenders

    @adamziel
    adamziel committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    fec0432 View commit details
    Browse the repository at this point in the history

  7. Document the BaseTypes namespace

    @adamziel
    adamziel committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    df1080c View commit details
    Browse the repository at this point in the history

  8. Lint

    @adamziel
    adamziel committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    d1c4dfb View commit details
    Browse the repository at this point in the history

  9. Lint the docstring in base-types.ts

    @adamziel
    adamziel committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    97bc553 View commit details
    Browse the repository at this point in the history

  10. Rename the BaseTypes namespace to WPBaseTypes

    @adamziel
    adamziel committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    80b7610 View commit details
    Browse the repository at this point in the history

  11. Add more commentary to the Extending section

    @adamziel
    adamziel committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    db67911 View commit details
    Browse the repository at this point in the history

  12. Add a comma

    @adamziel
    adamziel committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    4509bd2 View commit details
    Browse the repository at this point in the history

  13. Clarify the warning about type safety

    @adamziel
    adamziel committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    466dd5f View commit details
    Browse the repository at this point in the history

  14. Restore the first sentence of the warning

    @adamziel
    adamziel committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    a84b420 View commit details
    Browse the repository at this point in the history

  15. Link to the types readme in core-data readme

    @adamziel
    adamziel committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    0ab8ed7 View commit details
    Browse the repository at this point in the history

  16. Merge branch 'trunk' into ts/add-core-data-types

    @adamziel
    adamziel authored Feb 22, 2022
    Configuration menu
    Copy the full SHA
    2ce3ce0 View commit details
    Browse the repository at this point in the history

  17. Do not publish the data types

    @adamziel
    adamziel committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    dde0888 View commit details
    Browse the repository at this point in the history

  18. Rename WPBaseTypes to CoreBaseEntityTypes

    @adamziel
    adamziel committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    669f289 View commit details
    Browse the repository at this point in the history

  19. Rename CoreBaseEntityTypes to BaseEntityTypes

    @adamziel
    adamziel committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    adfd612 View commit details
    Browse the repository at this point in the history

  20. Fix a typo (extends -> extend)

    @adamziel
    adamziel committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    0fbd96f View commit details
    Browse the repository at this point in the history