-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix UI broken due to error when deleting first item in canvas. #38775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
An existing feature does not function as intended
[Feature] List View
Menu item in the top toolbar to select blocks from a list of links.
labels
Feb 14, 2022
talldan
requested review from
ntwb,
nerrad,
ajitbohra and
ellatrix
as code owners
February 14, 2022 03:49
Size Change: +29 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Feb 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fix makes sense to me 👍
cbravobernal
changed the title
Fix list view error when deleting first item in canvas
Fix UI broken due to error when deleting first item in canvas.
Feb 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] List View
Menu item in the top toolbar to select blocks from a list of links.
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #38763
I'm unsure of the root cause of this bug, but it's likely to be some kind of synchronization issue with
useSelect
- there have been other instances of this kind of bug. See #32088 and the related issue #29498 for more info.I think the problem is that the fix in #32088 wouldn't extend to
useBlockDisplayInformation
—it avoids throwing an error by instead returningnull
.ListView
doesn't handle thatnull
value, which it should. I imagine TypeScript wouldn't have caught this bug.Testing Instructions
I found this one difficult to reproduce consistently. I had most luck reproducing with a fairly complex navigation block as the first block, and then doing the following:
I've added some end to end test coverage, but because of the inconsistent nature of the bug, it's hard to say how successful this test will be.
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.js
files for terms that need renaming or removal).