Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnitControl: tidy up utils and types #38987

Merged
merged 38 commits into from
Mar 2, 2022
Merged

UnitControl: tidy up utils and types #38987

merged 38 commits into from
Mar 2, 2022

Commits on Mar 2, 2022

  1. UnitControl: tidy up utils types and logic

    @ciampo
    ciampo committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    0a1e48c View commit details
    Browse the repository at this point in the history

  2. UnitControl: update components following the changes in the utils

    @ciampo
    ciampo committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    b6ee1da View commit details
    Browse the repository at this point in the history

  3. UnitControl: Update tests

    @ciampo
    ciampo committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    72f23db View commit details
    Browse the repository at this point in the history

  4. Update usages in @wordpress/block-editor package

    @ciampo
    ciampo committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    b6c7c40 View commit details
    Browse the repository at this point in the history

  5. Allow rawValue to be undefined (as originally) in `parseQuantityA… 

    …ndUnitFromRawValue`
    @ciampo
    ciampo committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    06bebe2 View commit details
    Browse the repository at this point in the history

  6. Update usage of utils across @wordpress/components package

    @ciampo
    ciampo committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    fd9be2e View commit details
    Browse the repository at this point in the history

  7. Use empty array instead of false for WPUnitControlUnit[] type

    @ciampo
    ciampo committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    446803b View commit details
    Browse the repository at this point in the history

  8. Default value of ` in BoxControl`

    @ciampo
    ciampo committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    8bcb7b9 View commit details
    Browse the repository at this point in the history

  9. BoxControl: use undeefined instead of null when sending values … 

    …to `UnitControl`
    @ciampo
    ciampo committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    d4fa662 View commit details
    Browse the repository at this point in the history

  10. UnitCotnrol: rewrite onChange handlers to be closer to original cod… 

    …e, and fallback to `` more often
    @ciampo
    ciampo committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    346d137 View commit details
    Browse the repository at this point in the history

  11. Add null check to parsing logic for added resiliance

    @ciampo
    ciampo committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    b1b940b View commit details
    Browse the repository at this point in the history

  12. Rename variable in border radius control

    @ciampo
    ciampo committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    f46fb72 View commit details
    Browse the repository at this point in the history

  13. Rename variable in box control

    @ciampo
    ciampo committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    e2435b5 View commit details
    Browse the repository at this point in the history

  14. Fallback parsed quantity to `` in UnitControl

    @ciampo
    ciampo committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    b65e4b5 View commit details
    Browse the repository at this point in the history

  15. Use undefined instead of null when passing values to `UnitControl… 

    …` in `BorderRadiusControl`
    @ciampo
    ciampo committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    31badfc View commit details
    Browse the repository at this point in the history

  16. UnitControl: allow value to be undefined, and add further resil… 

    …iance agaist `null` values
    @ciampo
    ciampo committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    a5039b3 View commit details
    Browse the repository at this point in the history

  17. Adjust border-radius-control unit tests to return undefined instead… 

    … of `null`
    @ciampo
    ciampo committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    ea8addf View commit details
    Browse the repository at this point in the history

  18. Use empty array instead of false for list of units

    @ciampo
    ciampo committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    1ebe584 View commit details
    Browse the repository at this point in the history

  19. Update README

    @ciampo
    ciampo committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    4fd9e4d View commit details
    Browse the repository at this point in the history

  20. CHANGELOG

    @ciampo
    ciampo committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    16fe20f View commit details
    Browse the repository at this point in the history

  21. Border control: update test names

    @ciampo
    ciampo committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    3384883 View commit details
    Browse the repository at this point in the history

  22. Native components: remove unnecessary comments, fix default value of … 

    …units
    @ciampo
    ciampo committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    0034bf7 View commit details
    Browse the repository at this point in the history

  23. Undo native components runtime change

    @ciampo
    ciampo committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    e2d4cda View commit details
    Browse the repository at this point in the history

  24. valueToReturn => quantityToReturn

    @ciampo
    ciampo committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    266cb58 View commit details
    Browse the repository at this point in the history

  25. Clarify comment

    @ciampo
    ciampo committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    01eff34 View commit details
    Browse the repository at this point in the history

  26. No more units of units

    @ciampo
    ciampo committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    4d617e7 View commit details
    Browse the repository at this point in the history

  27. Clarify default unit docs

    @ciampo
    ciampo committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    44eecf4 View commit details
    Browse the repository at this point in the history

  28. Reinstantiate the filterUnitsWithSettings test chacking for false… 

    … inputs
    @ciampo
    ciampo committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    7e6f605 View commit details
    Browse the repository at this point in the history

  29. Break long JSDocs over multiple lines

    @ciampo
    ciampo committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    988646c View commit details
    Browse the repository at this point in the history

  30. Update useCustomUnits usages to pass numbers for the default unit q… 

    …uantity values
    @ciampo
    ciampo committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    2c49ab7 View commit details
    Browse the repository at this point in the history

  31. Reintroduce isArray check in getUnitsWithCurrentUnit

    @ciampo
    ciampo committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    ee541f4 View commit details
    Browse the repository at this point in the history

  32. Remove unnecessary NaN check, redundant next to isFinite

    @ciampo
    ciampo committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    f84f6b7 View commit details
    Browse the repository at this point in the history

  33. Simply matchedUnit computation using optional chaining syntax

    @ciampo
    ciampo committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    b44805c View commit details
    Browse the repository at this point in the history

  34. Remove undefined default unit quantity values

    @ciampo
    ciampo committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    98e1d44 View commit details
    Browse the repository at this point in the history

  35. Add prop types reminder

    @ciampo
    ciampo committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    a532f68 View commit details
    Browse the repository at this point in the history

  36. Update react native files

    @ciampo
    ciampo committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    2be3ac5 View commit details
    Browse the repository at this point in the history

  37. Rename variable after rebase

    @ciampo
    ciampo committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    49b645b View commit details
    Browse the repository at this point in the history

  38. Rename function in tests after rebase

    @ciampo
    ciampo committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    4efc349 View commit details
    Browse the repository at this point in the history