Image: Use layout.wideSize as ResizableBox max-width
#39678
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
|
I was initially trying to solve #26715, but the image still can go off-canvas on smaller screens. |
|
Size Change: +19 B (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
ntsekouras
reviewed
Mar 23, 2022
| // The block will try to use a wide layout size defined in the `theme.json` | ||
| // or fall back to the editor max-width + some wiggle-room. | ||
| const maxWidthBuffer = wideSize | ||
| ? parseInt( wideSize, 10 ) |
There was a problem hiding this comment.
wideSize might not be in px and that could result to quite unexpected results. Also shouldn't we take into account if an image is inside a container with wideSize set?
There was a problem hiding this comment.
wideSize might not be in px and that could result to quite unexpected results.
I didn't know all the theme.json files I checked had px specified. But it shouldn't be problem all the following will return 1000:
parseInt('1000rem', 10);
parseInt('1000', 10);
parseInt(1000, 10);Also shouldn't we take into account if an image is inside a container with wideSize set?
The current implementation has the same issue. Ideally, we want ResizableBox to have max-width: 100%, but currently, it only accepts px values. Here're some details: #11846 (comment)
There was a problem hiding this comment.
But it shouldn't be problem all the following will return 1000:
Yes, but if we have something like 50%, it will make the max width 50px. Maybe we should try to improve when we only have a px value? In addition if the value here is smaller than than the viewport it keeps the image contained and I noticed some distortion of the height in that case when I stop dragging.
Screen.Recording.2022-03-23.at.4.04.16.PM.mov
The video is with wideSize: 500px.
There was a problem hiding this comment.
Good point. I'll look into this tomorrow. Thanks, Nik!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR updates Image block to use
layout.wideSizefromtheme.jsonResizableBox max-width when available. I also adjusted the ratio for Classic Themes.Why?
Related #11846.
Now that themes can provide value for their wide layout size, I think it makes sense for this value to be the max-width of the resizable area.
How?
Updates
maxWidthBufferto uselayout.wideSize.Testing Instructions
Screenshots or screencast
CleanShot.2022-03-23.at.12.37.49.mp4