Revert "[Document Settings]: Add summary panel version 1" #40128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ae657f3.
Mamaduka
approved these changes
Apr 7, 2022
|
Size Change: -765 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
|
Thank you! Landing this feature in the plugin, even if just for a few days, has highlighted a few things that ultimately suggests it needs a little more time in the oven, but also that it should return in the future based on what we've learned so far! The main piece that has been great is the the colophon-like imprint appearance the panel gives off. It is in a very literal sense, a summary of the document, and serves to provide an elegant overview. In fact, when this returns, we should consider adding and integrating this summary also in the pre-publish flow. What landed, however, was a minimal V1 version of what was outlined in the original ticket, missing a few key features such as the ellipsis control to manage items inside. In effect this omission came with a few downsides:
Both of these issues feel very solvable through the ellipsis functionality, letting us find an interface that can manage prominence while still generating a summary of metadata intentionally added. The PR and brief time in trunk has definitely provided valuable insights to further guide the direction of #39082, so thank you all for letting us try this. Ultimately the V1 was perhaps too small, and at the same time, too big of a change to land for 6.0. Let's convert it to a branch again, and let it evolve so it can return in the future 🚀 |
|
Fixes #40124. |
|
It sounds like a very good idea keeping the summary panel in the plugin for a while so that we can get used to it, and over time also notice various things that will need to be adjusted before adding it into core. |
|
Is there still a branch where the panel can be tested? |
I guess you can check the original PR. |
|
It's worth noting that a new variant of this would likely keep the Summary panel static rather than editable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #39973
Fixes: #40124
We are going to exclude
Post summarypanel from6.0as it's kind of big change in the last minute and it might need a bit more testing/feedback in the plugin.