Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Style engine: split methods to generate css and classnames #42144

Closed
wants to merge 2 commits into from

Conversation

ramonjd
Copy link
Member

@ramonjd ramonjd commented Jul 5, 2022

🚧

Maybe we don't actually need this.

The current generate functions are very block support-specific. Block supports require CSS and classnames.

Moreover, if we are to generate semantic classnames for block supports in the future, the array() return value is already there to accommodate.

It'd save us a loop too 😄

What?

Create two methods wp_style_engine_generate_classnames and wp_style_engine_generate_css, both of which return strings.

This avoids returning array( 'css' => '', 'classnames' => '' ), which doesn't apply in all contexts

Why?

How?

Testing Instructions

Screenshots or screencast

@ramonjd ramonjd changed the title Style engine: split methods to generate css and classnames [WIP] Style engine: split methods to generate css and classnames Jul 6, 2022
@ramonjd ramonjd closed this Jul 15, 2022
@ramonjd ramonjd deleted the update/style-engine-split_css_and_classnames branch July 15, 2022 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🗄 Closed / not merged
Development

Successfully merging this pull request may close these issues.

1 participant