[WIP] Style engine: split methods to generate css and classnames #42144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧
Maybe we don't actually need this.
The current generate functions are very block support-specific. Block supports require CSS and classnames.
Moreover, if we are to generate semantic classnames for block supports in the future, the
array()
return value is already there to accommodate.It'd save us a loop too 😄
What?
Create two methods
wp_style_engine_generate_classnames
andwp_style_engine_generate_css
, both of which return strings.This avoids returning
array( 'css' => '', 'classnames' => '' )
, which doesn't apply in all contextsWhy?
How?
Testing Instructions
Screenshots or screencast