Transforms: add group unwrap #42685
Merged
Transforms: add group unwrap #42685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Block] Quote
|
Size Change: +124 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
ellatrix
commented
Jul 26, 2022
| @@ -490,8 +491,7 @@ export function switchToBlockType( blocks, name ) { | |||
| transformationsTo, | |||
| ( t ) => | |||
| t.type === 'block' && | |||
| ( isWildcardBlockTransform( t ) || | |||
There was a problem hiding this comment.
Wildcard to transforms (a.k.a. unwrap transforms) don't make sense to be considered when looking for a specific block transform.
E.g. if the quote block registers an unwrap transform, it shouldn't be considered when you transform a quote to a particular other block like pull quote.
The wildcard transforms only make sense from "from" transforms, which means transforming from random mix of blocks to the block that registers it.
E.g. when a quote block registers a "from" wildcard transform, it should be considered when switching block type to quote.
There was a problem hiding this comment.
Should we add this to the transforms docs?
|
This doesn't make a lot of sense to me from a design perspective:
I think we should revert this and work a bit further on the presentation. |
16 tasks
30 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Since #25892 we now allow an unwrap transform (which is a "to"
*transform). This means that the nested blocks will be unwrapped.This is also useful for the group block. Currently there's no way to ungroup from the block switcher, although there's a dedicated button in the block settings menu.
This PR also fixes an issue with the Quote unwrap where backgound color etc. of the quote would be transferred to the children.
Why?
It's easier to find the transform in the dedicated menu for transforms (the block switcher).
How?
Testing Instructions
Create a group blocks. Try unwrapping contents via the block switcher.
Screenshots or screencast